Commit 9bd43a61 authored Jun 15, 2020 by Maxime Ripard Committed by Stephen Boyd Jun 19, 2020

clk: bcm: rpi: Make sure the clkdev lookup is removed

The clkdev lookup created for the cpufreq device is never removed if
there's an issue later in probe or at module removal time.

Let's convert to the managed variant of the clk_hw_register_clkdev function
to make sure it happens.

Cc: Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/075e2c6d315eccdaf8fb72b320712b86e6c25b22.1592210452.git-series.maxime@cerno.tech

Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 55ee6a99

drivers/clk/bcm/clk-raspberrypi.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -245,7 +245,8 @@ static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi)
		return ret;
		}

		ret = clk_hw_register_clkdev(&raspberrypi_clk_pllb_arm.hw,
		ret = devm_clk_hw_register_clkdev(rpi->dev,
		&raspberrypi_clk_pllb_arm.hw,
		NULL, "cpu0");
		if (ret) {
		dev_err(rpi->dev, "Failed to initialize clkdev\n");

Admin message