Commit 9bbd7374 authored Jul 05, 2011 by Paul Turner Committed by Ingo Molnar Jul 21, 2011

sched: update correct entity's runtime in check_preempt_wakeup()



While looking at check_preempt_wakeup() I realized that we are
potentially updating the wrong entity in the fair-group scheduling
case. In this case the current task's cfs_rq may not be the same as
the one used for the comparison between the waking task and the
existing task's vruntime.

This potentially results in us using a stale vruntime in the
pre-emption decision, providing a small false preference for the
previous task. The effects of this are bounded since we always
perform a hierarchal update on the tick.

Signed-off-by: Paul Turner <pjt@google.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/CAPM31R+2Ke2urUZKao5W92_LupdR4AYEv-EZWiJ3tG=tEes2cw@mail.gmail.com


Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 994bf1c9

kernel/sched_fair.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1919,8 +1919,8 @@ static void check_preempt_wakeup(struct rq rq, struct task_struct p, int wake_
		if (!sched_feat(WAKEUP_PREEMPT))
		return;

		update_curr(cfs_rq);
		find_matching_se(&se, &pse);
		update_curr(cfs_rq_of(se));
		BUG_ON(!pse);
		if (wakeup_preempt_entity(se, pse) == 1) {
		/*

Admin message