Commit 9bbb3329 authored Oct 13, 2020 by Tom Zanussi Committed by Steven Rostedt (VMware) Oct 15, 2020

tracing: Check that the synthetic event and field names are legal

Call the is_good_name() function used by probe events to make sure
synthetic event and field names don't contain illegal characters and
cause unexpected parsing of synthetic event commands.

Link: https://lkml.kernel.org/r/c4d4bb59d3ac39bcbd70fba0cf837d6b1cedb015.1602598160.git.zanussi@kernel.org

Fixes: 4b147936 (tracing: Add support for 'synthetic' events)
Reported-by: Masami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Tested-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent 42d120e2

kernel/trace/trace_events_synth.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -572,6 +572,10 @@ static struct synth_field parse_synth_field(int argc, const char *argv,
		ret = -ENOMEM;
		goto free;
		}
		if (!is_good_name(field->name)) {
		ret = -EINVAL;
		goto free;
		}

		if (field_type[0] == ';')
		field_type++;
		@@ -1112,6 +1116,11 @@ static int __create_synth_event(int argc, const char name, const char *argv)

		mutex_lock(&event_mutex);

		if (!is_good_name(name)) {
		ret = -EINVAL;
		goto out;
		}

		event = find_synth_event(name);
		if (event) {
		ret = -EEXIST;