mm, memory_hotplug: fix memmap initialization (9bb5a391) · Commits · 戴 / test

Bharata has noticed that onlining a newly added memory doesn't increase the total memory, pointing to commit ("mm: stop zeroing memory during allocation in vmemmap") as a culprit. This commit has changed the way how the memory for memmaps is initialized and moves it from the allocation time to the initialization time. This works properly for the early memmap init path. It doesn't work for the memory hotplug though because we need to mark page as reserved when the sparsemem section is created and later initialize it completely during onlining. memmap_init_zone is called in the early stage of onlining. With the current code it calls __init_single_page and as such it clears up the whole stage and therefore online_pages_range skips those pages. Fix this by skipping mm_zero_struct_page in __init_single_page for memory hotplug path. This is quite uggly but unifying both early init and memory hotplug init paths is a large project. Make sure we plug the regression at least. Link: http://lkml.kernel.org/r/20180130101141.GW21609@dhcp22.suse.cz Fixes: ("mm: stop zeroing memory during allocation in vmemmap") Signed-off-by:

Michal Hocko <mhocko@suse.com> Reported-by:

Bharata B Rao <bharata@linux.vnet.ibm.com> Tested-by:

Bharata B Rao <bharata@linux.vnet.ibm.com> Reviewed-by:

Pavel Tatashin <pasha.tatashin@oracle.com> Cc: Steven Sistare <steven.sistare@oracle.com> Cc: Daniel Jordan <daniel.m.jordan@oracle.com> Cc: Bob Picco <bob.picco@oracle.com> Cc: <stable@vger.kernel.org> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

mm/page_alloc.c

+14 −8

Original line number	Diff line number	Diff line
		@@ -1177,8 +1177,9 @@ static void free_one_page(struct zone *zone,
		}

		static void __meminit __init_single_page(struct page *page, unsigned long pfn,
		unsigned long zone, int nid)
		unsigned long zone, int nid, bool zero)
		{
		if (zero)
		mm_zero_struct_page(page);
		set_page_links(page, zone, nid, pfn);
		init_page_count(page);
		@@ -1194,9 +1195,9 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn,
		}

		static void __meminit __init_single_pfn(unsigned long pfn, unsigned long zone,
		int nid)
		int nid, bool zero)
		{
		return __init_single_page(pfn_to_page(pfn), pfn, zone, nid);
		return __init_single_page(pfn_to_page(pfn), pfn, zone, nid, zero);
		}

		#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
		@@ -1217,7 +1218,7 @@ static void __meminit init_reserved_page(unsigned long pfn)
		if (pfn >= zone->zone_start_pfn && pfn < zone_end_pfn(zone))
		break;
		}
		__init_single_pfn(pfn, zid, nid);
		__init_single_pfn(pfn, zid, nid, true);
		}
		#else
		static inline void init_reserved_page(unsigned long pfn)
		@@ -1534,7 +1535,7 @@ static unsigned long __init deferred_init_pages(int nid, int zid,
		} else {
		page++;
		}
		__init_single_page(page, pfn, zid, nid);
		__init_single_page(page, pfn, zid, nid, true);
		nr_pages++;
		}
		return (nr_pages);
		@@ -5399,15 +5400,20 @@ not_early:
		* can be created for invalid pages (for alignment)
		* check here not to call set_pageblock_migratetype() against
		* pfn out of zone.
		*
		* Please note that MEMMAP_HOTPLUG path doesn't clear memmap
		* because this is done early in sparse_add_one_section
		*/
		if (!(pfn & (pageblock_nr_pages - 1))) {
		struct page *page = pfn_to_page(pfn);

		__init_single_page(page, pfn, zone, nid);
		__init_single_page(page, pfn, zone, nid,
		context != MEMMAP_HOTPLUG);
		set_pageblock_migratetype(page, MIGRATE_MOVABLE);
		cond_resched();
		} else {
		__init_single_pfn(pfn, zone, nid);
		__init_single_pfn(pfn, zone, nid,
		context != MEMMAP_HOTPLUG);
		}
		}
		}

Admin message