Commit 9bb40f01 authored by Linus Torvalds's avatar Linus Torvalds
Browse files
Pull backlight fix from Lee Jones:
 "Fix brightness levels when !DT in pwm_bl driver"

* tag 'backlight-fixes-4.20' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight:
  backlight: pwm_bl: Fix brightness levels for non-DT case.
parents 1dffab5e d347d0c8
Loading
Loading
Loading
Loading
+35 −6
Original line number Diff line number Diff line
@@ -562,7 +562,30 @@ static int pwm_backlight_probe(struct platform_device *pdev)
		goto err_alloc;
	}

	if (!data->levels) {
	if (data->levels) {
		/*
		 * For the DT case, only when brightness levels is defined
		 * data->levels is filled. For the non-DT case, data->levels
		 * can come from platform data, however is not usual.
		 */
		for (i = 0; i <= data->max_brightness; i++) {
			if (data->levels[i] > pb->scale)
				pb->scale = data->levels[i];

			pb->levels = data->levels;
		}
	} else if (!data->max_brightness) {
		/*
		 * If no brightness levels are provided and max_brightness is
		 * not set, use the default brightness table. For the DT case,
		 * max_brightness is set to 0 when brightness levels is not
		 * specified. For the non-DT case, max_brightness is usually
		 * set to some value.
		 */

		/* Get the PWM period (in nanoseconds) */
		pwm_get_state(pb->pwm, &state);

		ret = pwm_backlight_brightness_default(&pdev->dev, data,
						       state.period);
		if (ret < 0) {
@@ -570,7 +593,6 @@ static int pwm_backlight_probe(struct platform_device *pdev)
				"failed to setup default brightness table\n");
			goto err_alloc;
		}
	}

		for (i = 0; i <= data->max_brightness; i++) {
			if (data->levels[i] > pb->scale)
@@ -578,6 +600,13 @@ static int pwm_backlight_probe(struct platform_device *pdev)

			pb->levels = data->levels;
		}
	} else {
		/*
		 * That only happens for the non-DT case, where platform data
		 * sets the max_brightness value.
		 */
		pb->scale = data->max_brightness;
	}

	pb->lth_brightness = data->lth_brightness * (state.period / pb->scale);