Commit 9ba27794 authored Jun 06, 2005 by Michael Chan Committed by David S. Miller Jun 06, 2005

[TG3] Fix link failure in 5701



On some 5701 devices with older bootcode, the LED configuration bits in
SRAM may be invalid with value zero. The fix is to check for invalid
bits (0) and default to PHY 1 mode. Incorrect LED mode will lead to
error in programming the PHY.

Thanks to Grant Grundler for debugging the problem.

>From Grant:
| In May, 2004,  tg3 v3.4 changed how MAC_LED_CTRL (0x40c) was getting
| programmed and how to determine what to program into LED_CTRL. The new
| code trusted NIC_SRAM_DATA_CFG (0x00000b58) to indicate what to write
| to LED_CTRL and MII EXT_CTRL registers. On "IOX Core Lan", SRAM was
| saying MODE_MAC (0x0) and that doesn't work.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 49cabf49

drivers/net/tg3.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -8560,6 +8560,16 @@ static void __devinit tg3_get_eeprom_hw_cfg(struct tg3 *tp)

		case NIC_SRAM_DATA_CFG_LED_MODE_MAC:
		tp->led_ctrl = LED_CTRL_MODE_MAC;

		/* Default to PHY_1_MODE if 0 (MAC_MODE) is
		* read on some older 5700/5701 bootcode.
		*/
		if (GET_ASIC_REV(tp->pci_chip_rev_id) ==
		ASIC_REV_5700 \|\|
		GET_ASIC_REV(tp->pci_chip_rev_id) ==
		ASIC_REV_5701)
		tp->led_ctrl = LED_CTRL_MODE_PHY_1;

		break;

		case SHASTA_EXT_LED_SHARED:

Admin message