Commit 9b7ebff2 authored Nov 05, 2018 by Sean Christopherson Committed by Paolo Bonzini Dec 21, 2018

KVM: x86: Remove KF() macro placeholder

Although well-intentioned, keeping the KF() definition as a hint for
handling scattered CPUID features may be counter-productive. Simply
redefining the bit position only works for directly manipulating the
guest's CPUID leafs, e.g. it doesn't make guest_cpuid_has() magically
work. Taking an alternative approach, e.g. ensuring the bit position
is identical between the Linux-defined and hardware-defined features,
may be a simpler and/or more effective method of exposing scattered
features to the guest.

Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

parent 788fc1e9

arch/x86/kvm/cpuid.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -67,9 +67,6 @@ u64 kvm_supported_xcr0(void)

		#define F(x) bit(X86_FEATURE_##x)

		/* For scattered features from cpufeatures.h; we currently expose none */
		#define KF(x) bit(KVM_CPUID_BIT_##x)

		int kvm_update_cpuid(struct kvm_vcpu *vcpu)
		{
		struct kvm_cpuid_entry2 *best;

Admin message