ASoC: stm32: sai: fix sysclk management on shutdown (9b7a7f92) · Commits · 戴 / test

The commit below, adds a call to sysclk callback on shutdown. This introduces a regression in stm32 SAI driver, as some clock services are called twice, leading to unbalanced calls. Move processing related to mclk from shutdown to sysclk callback. When requested frequency is 0, assume shutdown and release mclk. Fixes: ("SoC: simple-card-utils: set 0Hz to sysclk when shutdown") Signed-off-by:

Olivier Moysan <olivier.moysan@st.com> Link: https://lore.kernel.org/r/20191018082040.31022-1-olivier.moysan@st.com Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/stm/stm32_sai_sub.c

+11 −10

Original line number	Diff line number	Diff line
		@@ -505,10 +505,20 @@ static int stm32_sai_set_sysclk(struct snd_soc_dai *cpu_dai,
		if (dir == SND_SOC_CLOCK_OUT && sai->sai_mclk) {
		ret = regmap_update_bits(sai->regmap, STM_SAI_CR1_REGX,
		SAI_XCR1_NODIV,
		(unsigned int)~SAI_XCR1_NODIV);
		freq ? 0 : SAI_XCR1_NODIV);
		if (ret < 0)
		return ret;

		/* Assume shutdown if requested frequency is 0Hz */
		if (!freq) {
		/* Release mclk rate only if rate was actually set */
		if (sai->mclk_rate) {
		clk_rate_exclusive_put(sai->sai_mclk);
		sai->mclk_rate = 0;
		}
		return 0;
		}

		/* If master clock is used, set parent clock now */
		ret = stm32_sai_set_parent_clock(sai, freq);
		if (ret)
		@@ -1093,15 +1103,6 @@ static void stm32_sai_shutdown(struct snd_pcm_substream *substream,

		regmap_update_bits(sai->regmap, STM_SAI_IMR_REGX, SAI_XIMR_MASK, 0);

		regmap_update_bits(sai->regmap, STM_SAI_CR1_REGX, SAI_XCR1_NODIV,
		SAI_XCR1_NODIV);

		/* Release mclk rate only if rate was actually set */
		if (sai->mclk_rate) {
		clk_rate_exclusive_put(sai->sai_mclk);
		sai->mclk_rate = 0;
		}

		clk_disable_unprepare(sai->sai_ck);

		spin_lock_irqsave(&sai->irq_lock, flags);

Admin message