Commit 9b6d2510 authored Feb 20, 2009 by Ilpo Järvinen Committed by Linus Torvalds Feb 20, 2009

sx.c: fix dbl statement if - add missing braces



Caused by 736d5453 (sx.c: fix missed unlock_kernel() on error path in
sx_fw_ioctl()).  You guys keep breaking things this way in every single
kernel release in at least couple of places...  :-(

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Acked-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ad444684

drivers/char/sx.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1746,9 +1746,10 @@ static long sx_fw_ioctl(struct file *filp, unsigned int cmd,
		sx_dprintk(SX_DEBUG_FIRMWARE, "returning type= %ld\n", rc);
		break;
		case SXIO_DO_RAMTEST:
		if (sx_initialized) /* Already initialized: better not ramtest the board. */
		if (sx_initialized) { /* Already initialized: better not ramtest the board. */
		rc = -EPERM;
		break;
		}
		if (IS_SX_BOARD(board)) {
		rc = do_memtest(board, 0, 0x7000);
		if (!rc)

Admin message