drm/i915/pm: use intel de functions for forcewake register access (9b6320aa) · Commits · 戴 / test

Move away from I915_READ_FW() and I915_WRITE_FW() in display code, and switch to using intel_de_read_fw() and intel_de_write_fw(), respectively. No functional changes. Reviewed-by:

Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by:

Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by:

Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200123140004.14136-6-jani.nikula@intel.com

drivers/gpu/drm/i915/intel_pm.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -5061,9 +5061,10 @@ static void skl_ddb_entry_write(struct drm_i915_private *dev_priv,
		const struct skl_ddb_entry *entry)
		{
		if (entry->end)
		I915_WRITE_FW(reg, (entry->end - 1) << 16 \| entry->start);
		intel_de_write_fw(dev_priv, reg,
		(entry->end - 1) << 16 \| entry->start);
		else
		I915_WRITE_FW(reg, 0);
		intel_de_write_fw(dev_priv, reg, 0);
		}

		static void skl_write_wm_level(struct drm_i915_private *dev_priv,
		@@ -5079,7 +5080,7 @@ static void skl_write_wm_level(struct drm_i915_private *dev_priv,
		val \|= level->plane_res_b;
		val \|= level->plane_res_l << PLANE_WM_LINES_SHIFT;

		I915_WRITE_FW(reg, val);
		intel_de_write_fw(dev_priv, reg, val);
		}

		void skl_write_plane_wm(struct intel_plane *plane,

Admin message