Unverified Commit 9b562437 authored Jul 31, 2019 by Chuhong Yuan Committed by Maxime Ripard Aug 03, 2019

drm/modes: Fix unterminated strncpy



strncpy(dest, src, strlen(src)) leads to unterminated
dest, which is dangerous.
Fix it by using strscpy.

Fixes: 3aeeb13d ("drm/modes: Support modes names on the command line")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190731020140.3529-1-hslester96@gmail.com

parent 58540594

drivers/gpu/drm/drm_modes.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1770,7 +1770,9 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option,
	}		}

	if (named_mode) {		if (named_mode) {
	strncpy(mode->name, name, mode_end);		if (mode_end + 1 > DRM_DISPLAY_MODE_LEN)
			return false;
			strscpy(mode->name, name, mode_end + 1);
	} else {		} else {
	ret = drm_mode_parse_cmdline_res_mode(name, mode_end,		ret = drm_mode_parse_cmdline_res_mode(name, mode_end,
	parse_extras,		parse_extras,

Admin message