Commit 9b537997 authored Oct 22, 2019 by Yunfeng Ye Committed by Herbert Xu Nov 01, 2019

crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()



A warning is found by the static code analysis tool:
  "Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Fixes: 67cfa5d3 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 691505a8

arch/arm64/crypto/aes-neonbs-glue.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
		goto xts_tail;

		kernel_neon_end();
		skcipher_walk_done(&walk, nbytes);
		err = skcipher_walk_done(&walk, nbytes);
		}

		if (err \|\| likely(!tail))

Admin message