Commit 9b492cf5 authored by Xunlei Pang's avatar Xunlei Pang Committed by Linus Torvalds
Browse files

kexec: introduce a protection mechanism for the crashkernel reserved memory 



For the cases that some kernel (module) path stamps the crash reserved
memory(already mapped by the kernel) where has been loaded the second
kernel data, the kdump kernel will probably fail to boot when panic
happens (or even not happens) leaving the culprit at large, this is
unacceptable.

The patch introduces a mechanism for detecting such cases:

1) After each crash kexec loading, it simply marks the reserved memory
   regions readonly since we no longer access it after that.  When someone
   stamps the region, the first kernel will panic and trigger the kdump.
   The weak arch_kexec_protect_crashkres() is introduced to do the actual
   protection.

2) To allow multiple loading, once 1) was done we also need to remark
   the reserved memory to readwrite each time a system call related to
   kdump is made.  The weak arch_kexec_unprotect_crashkres() is introduced
   to do the actual protection.

The architecture can make its specific implementation by overriding
arch_kexec_protect_crashkres() and arch_kexec_unprotect_crashkres().

Signed-off-by: default avatarXunlei Pang <xlpang@redhat.com>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Minfei Huang <mhuang@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9eb8a659

include/linux/kexec.h

+2 −0
Original line number Original line Diff line number Diff line
@@ -317,6 +317,8 @@ int __weak arch_kexec_apply_relocations_add(const Elf_Ehdr *ehdr, 
					Elf_Shdr *sechdrs, unsigned int relsec);

					Elf_Shdr *sechdrs, unsigned int relsec);

int __weak arch_kexec_apply_relocations(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs,

int __weak arch_kexec_apply_relocations(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs,

					unsigned int relsec);

					unsigned int relsec);

void arch_kexec_protect_crashkres(void);

void arch_kexec_unprotect_crashkres(void);





#else /* !CONFIG_KEXEC_CORE */

#else /* !CONFIG_KEXEC_CORE */

struct pt_regs;

struct pt_regs;

kernel/kexec.c

+8 −1
Original line number Original line Diff line number Diff line
@@ -167,8 +167,12 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments, 
		return -EBUSY;

		return -EBUSY;





	dest_image = &kexec_image;

	dest_image = &kexec_image;

	if (flags & KEXEC_ON_CRASH)

	if (flags & KEXEC_ON_CRASH) {

		dest_image = &kexec_crash_image;

		dest_image = &kexec_crash_image;

		if (kexec_crash_image)

			arch_kexec_unprotect_crashkres();

	}



	if (nr_segments > 0) {

	if (nr_segments > 0) {

		unsigned long i;

		unsigned long i;
@@ -211,6 +215,9 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments, 
	image = xchg(dest_image, image);

	image = xchg(dest_image, image);





out:

out:

	if ((flags & KEXEC_ON_CRASH) && kexec_crash_image)

		arch_kexec_protect_crashkres();



	mutex_unlock(&kexec_mutex);

	mutex_unlock(&kexec_mutex);

	kimage_free(image);

	kimage_free(image);

kernel/kexec_core.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -1563,3 +1563,9 @@ void __weak crash_map_reserved_pages(void) 




void __weak crash_unmap_reserved_pages(void)

void __weak crash_unmap_reserved_pages(void)

{}

{}



void __weak arch_kexec_protect_crashkres(void)

{}



void __weak arch_kexec_unprotect_crashkres(void)

{}

kernel/kexec_file.c

+7 −1
Original line number Original line Diff line number Diff line
@@ -274,8 +274,11 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, 
		return -EBUSY;

		return -EBUSY;





	dest_image = &kexec_image;

	dest_image = &kexec_image;

	if (flags & KEXEC_FILE_ON_CRASH)

	if (flags & KEXEC_FILE_ON_CRASH) {

		dest_image = &kexec_crash_image;

		dest_image = &kexec_crash_image;

		if (kexec_crash_image)

			arch_kexec_unprotect_crashkres();

	}





	if (flags & KEXEC_FILE_UNLOAD)

	if (flags & KEXEC_FILE_UNLOAD)

		goto exchange;

		goto exchange;
@@ -324,6 +327,9 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, 
exchange:

exchange:

	image = xchg(dest_image, image);

	image = xchg(dest_image, image);

out:

out:

	if ((flags & KEXEC_FILE_ON_CRASH) && kexec_crash_image)

		arch_kexec_protect_crashkres();



	mutex_unlock(&kexec_mutex);

	mutex_unlock(&kexec_mutex);

	kimage_free(image);

	kimage_free(image);

	return ret;

	return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE