Commit 9b3acc21 authored by Ronald S. Bultje's avatar Ronald S. Bultje Committed by Linus Torvalds
Browse files

[PATCH] fix vpx3220 offset issue in SECAM 



Fix bug #5404 in kernel bugzilla.

It basically updates the vpx3220 initialization tables with some newer
values that we've had in CVS for a while (and that, for some reason, never
ended up in the kernel...  must've gotten lost).  Those fix a ~16 pixels
noise at the top of the picture in at least SECAM, although (now that I
think about it) PAL was probably affected, also.

Signed-off-by: default avatarRonald S. Bultje <rbultje@ronald.bitfreak.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 0aec4867

drivers/media/video/vpx3220.c

+10 −12
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ static const unsigned short init_ntsc[] = { 
	0x8c, 640,		/* Horizontal length */

	0x8d, 640,		/* Number of pixels */

	0x8f, 0xc00,		/* Disable window 2 */

	0xf0, 0x173,		/* 13.5 MHz transport, Forced

	0xf0, 0x73,		/* 13.5 MHz transport, Forced

				 * mode, latch windows */

	0xf2, 0x13,		/* NTSC M, composite input */

	0xe7, 0x1e1,		/* Enable vertical standard
@@ -212,38 +212,36 @@ static const unsigned short init_ntsc[] = { 


static const unsigned short init_pal[] = {

	0x88, 23,		/* Window 1 vertical begin */

	0x89, 288 + 16,		/* Vertical lines in (16 lines

	0x89, 288,		/* Vertical lines in (16 lines

				 * skipped by the VFE) */

	0x8a, 288 + 16,		/* Vertical lines out (16 lines

	0x8a, 288,		/* Vertical lines out (16 lines

				 * skipped by the VFE) */

	0x8b, 16,		/* Horizontal begin */

	0x8c, 768,		/* Horizontal length */

	0x8d, 784, 		/* Number of pixels

				 * Must be >= Horizontal begin + Horizontal length */

	0x8f, 0xc00,		/* Disable window 2 */

	0xf0, 0x177,		/* 13.5 MHz transport, Forced

	0xf0, 0x77,		/* 13.5 MHz transport, Forced

				 * mode, latch windows */

	0xf2, 0x3d1,		/* PAL B,G,H,I, composite input */

	0xe7, 0x261,		/* PAL/SECAM set to 288 + 16 lines 

				 * change to 0x241 for 288 lines */

	0xe7, 0x241,		/* PAL/SECAM set to 288 lines */

};



static const unsigned short init_secam[] = {

	0x88, 23  - 16,		/* Window 1 vertical begin */

	0x89, 288 + 16,		/* Vertical lines in (16 lines

	0x88, 23,		/* Window 1 vertical begin */

	0x89, 288,		/* Vertical lines in (16 lines

				 * skipped by the VFE) */

	0x8a, 288 + 16,		/* Vertical lines out (16 lines

	0x8a, 288,		/* Vertical lines out (16 lines

				 * skipped by the VFE) */

	0x8b, 16,		/* Horizontal begin */

	0x8c, 768,		/* Horizontal length */

	0x8d, 784,		/* Number of pixels

				 * Must be >= Horizontal begin + Horizontal length */

	0x8f, 0xc00,		/* Disable window 2 */

	0xf0, 0x177,		/* 13.5 MHz transport, Forced

	0xf0, 0x77,		/* 13.5 MHz transport, Forced

				 * mode, latch windows */

	0xf2, 0x3d5,		/* SECAM, composite input */

	0xe7, 0x261,		/* PAL/SECAM set to 288 + 16 lines 

				 * change to 0x241 for 288 lines */

	0xe7, 0x241,		/* PAL/SECAM set to 288 lines */

};



static const unsigned char init_common[] = {

CRA Git | Maintained and supported by SUSTech CRA and CCSE