Commit 9b3579fc authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf tests: Add breakpoint modify tests 



Adding to tests that aims on kernel breakpoint modification bugs.

First test creates HW breakpoint, tries to change it and checks it was
properly changed. It aims on kernel issue that prevents HW breakpoint to
be changed via ptrace interface.

The first test forks, the child sets itself as ptrace tracee and waits
in signal for parent to trace it, then it calls bp_1 and quits.

The parent does following steps:

 - creates a new breakpoint (id 0) for bp_2 function
 - changes that breakpoint to bp_1 function
 - waits for the breakpoint to hit and checks
   it has proper rip of bp_1 function

This test aims on an issue in kernel preventing to change disabled
breakpoints

Second test mimics the first one except for few steps
in the parent:
 - creates a new breakpoint (id 0) for bp_1 function
 - changes that breakpoint to bogus (-1) address
 - waits for the breakpoint to hit and checks
   it has proper rip of bp_1 function

This test aims on an issue in kernel disabling enabled
breakpoint after unsuccesful change.

Committer testing:

  # uname -a
  Linux jouet 4.18.0-rc8-00002-g1236568ee3cb #12 SMP Tue Aug 7 14:08:26 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
  # perf test -v "bp modify"
  62: x86 bp modify                                         :
  --- start ---
  test child forked, pid 25671
  in bp_1
  tracee exited prematurely 2
  FAILED arch/x86/tests/bp-modify.c:209 modify test 1 failed

  test child finished with -1
  ---- end ----
  x86 bp modify: FAILED!
  #

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Milind Chabbi <chabbi.milind@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180827091228.2878-2-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 1dc27f63

tools/perf/arch/x86/include/arch-tests.h

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ struct test; 
int test__rdpmc(struct test *test __maybe_unused, int subtest);

int test__perf_time_to_tsc(struct test *test __maybe_unused, int subtest);

int test__insn_x86(struct test *test __maybe_unused, int subtest);

int test__bp_modify(struct test *test, int subtest);



#ifdef HAVE_DWARF_UNWIND_SUPPORT

struct thread;

tools/perf/arch/x86/tests/Build

+1 −0
Original line number Diff line number Diff line
@@ -5,3 +5,4 @@ libperf-y += arch-tests.o 
libperf-y += rdpmc.o

libperf-y += perf-time-to-tsc.o

libperf-$(CONFIG_AUXTRACE) += insn-x86.o

libperf-$(CONFIG_X86_64) += bp-modify.o

tools/perf/arch/x86/tests/arch-tests.c

+6 −0
Original line number Diff line number Diff line
@@ -23,6 +23,12 @@ struct test arch_tests[] = { 
		.desc = "x86 instruction decoder - new instructions",

		.func = test__insn_x86,

	},

#endif

#if defined(__x86_64__)

	{

		.desc = "x86 bp modify",

		.func = test__bp_modify,

	},

#endif

	{

		.func = NULL,

tools/perf/arch/x86/tests/bp-modify.c

0 → 100644
+213 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

#include <linux/compiler.h>

#include <sys/types.h>

#include <sys/wait.h>

#include <sys/user.h>

#include <syscall.h>

#include <unistd.h>

#include <stdio.h>

#include <stdlib.h>

#include <sys/ptrace.h>

#include <asm/ptrace.h>

#include <errno.h>

#include "debug.h"

#include "tests/tests.h"

#include "arch-tests.h"



static noinline int bp_1(void)

{

	pr_debug("in %s\n", __func__);

	return 0;

}



static noinline int bp_2(void)

{

	pr_debug("in %s\n", __func__);

	return 0;

}



static int spawn_child(void)

{

	int child = fork();



	if (child == 0) {

		/*

		 * The child sets itself for as tracee and

		 * waits in signal for parent to trace it,

		 * then it calls bp_1 and quits.

		 */

		int err = ptrace(PTRACE_TRACEME, 0, NULL, NULL);



		if (err) {

			pr_debug("failed to PTRACE_TRACEME\n");

			exit(1);

		}



		raise(SIGCONT);

		bp_1();

		exit(0);

	}



	return child;

}



/*

 * This tests creates HW breakpoint, tries to

 * change it and checks it was properly changed.

 */

static int bp_modify1(void)

{

	pid_t child;

	int status;

	unsigned long rip = 0, dr7 = 1;



	child = spawn_child();



	waitpid(child, &status, 0);

	if (WIFEXITED(status)) {

		pr_debug("tracee exited prematurely 1\n");

		return TEST_FAIL;

	}



	/*

	 * The parent does following steps:

	 *  - creates a new breakpoint (id 0) for bp_2 function

	 *  - changes that breakponit to bp_1 function

	 *  - waits for the breakpoint to hit and checks

	 *    it has proper rip of bp_1 function

	 *  - detaches the child

	 */

	if (ptrace(PTRACE_POKEUSER, child,

		   offsetof(struct user, u_debugreg[0]), bp_2)) {

		pr_debug("failed to set breakpoint, 1st time: %s\n",

			 strerror(errno));

		goto out;

	}



	if (ptrace(PTRACE_POKEUSER, child,

		   offsetof(struct user, u_debugreg[0]), bp_1)) {

		pr_debug("failed to set breakpoint, 2nd time: %s\n",

			 strerror(errno));

		goto out;

	}



	if (ptrace(PTRACE_POKEUSER, child,

		   offsetof(struct user, u_debugreg[7]), dr7)) {

		pr_debug("failed to set dr7: %s\n", strerror(errno));

		goto out;

	}



	if (ptrace(PTRACE_CONT, child, NULL, NULL)) {

		pr_debug("failed to PTRACE_CONT: %s\n", strerror(errno));

		goto out;

	}



	waitpid(child, &status, 0);

	if (WIFEXITED(status)) {

		pr_debug("tracee exited prematurely 2\n");

		return TEST_FAIL;

	}



	rip = ptrace(PTRACE_PEEKUSER, child,

		     offsetof(struct user_regs_struct, rip), NULL);

	if (rip == (unsigned long) -1) {

		pr_debug("failed to PTRACE_PEEKUSER: %s\n",

			 strerror(errno));

		goto out;

	}



	pr_debug("rip %lx, bp_1 %p\n", rip, bp_1);



out:

	if (ptrace(PTRACE_DETACH, child, NULL, NULL)) {

		pr_debug("failed to PTRACE_DETACH: %s", strerror(errno));

		return TEST_FAIL;

	}



	return rip == (unsigned long) bp_1 ? TEST_OK : TEST_FAIL;

}



/*

 * This tests creates HW breakpoint, tries to

 * change it to bogus value and checks the original

 * breakpoint is hit.

 */

static int bp_modify2(void)

{

	pid_t child;

	int status;

	unsigned long rip = 0, dr7 = 1;



	child = spawn_child();



	waitpid(child, &status, 0);

	if (WIFEXITED(status)) {

		pr_debug("tracee exited prematurely 1\n");

		return TEST_FAIL;

	}



	/*

	 * The parent does following steps:

	 *  - creates a new breakpoint (id 0) for bp_1 function

	 *  - tries to change that breakpoint to (-1) address

	 *  - waits for the breakpoint to hit and checks

	 *    it has proper rip of bp_1 function

	 *  - detaches the child

	 */

	if (ptrace(PTRACE_POKEUSER, child,

		   offsetof(struct user, u_debugreg[0]), bp_1)) {

		pr_debug("failed to set breakpoint: %s\n",

			 strerror(errno));

		goto out;

	}



	if (ptrace(PTRACE_POKEUSER, child,

		   offsetof(struct user, u_debugreg[7]), dr7)) {

		pr_debug("failed to set dr7: %s\n", strerror(errno));

		goto out;

	}



	if (!ptrace(PTRACE_POKEUSER, child,

		   offsetof(struct user, u_debugreg[0]), (unsigned long) (-1))) {

		pr_debug("failed, breakpoint set to bogus address\n");

		goto out;

	}



	if (ptrace(PTRACE_CONT, child, NULL, NULL)) {

		pr_debug("failed to PTRACE_CONT: %s\n", strerror(errno));

		goto out;

	}



	waitpid(child, &status, 0);

	if (WIFEXITED(status)) {

		pr_debug("tracee exited prematurely 2\n");

		return TEST_FAIL;

	}



	rip = ptrace(PTRACE_PEEKUSER, child,

		     offsetof(struct user_regs_struct, rip), NULL);

	if (rip == (unsigned long) -1) {

		pr_debug("failed to PTRACE_PEEKUSER: %s\n",

			 strerror(errno));

		goto out;

	}



	pr_debug("rip %lx, bp_1 %p\n", rip, bp_1);



out:

	if (ptrace(PTRACE_DETACH, child, NULL, NULL)) {

		pr_debug("failed to PTRACE_DETACH: %s", strerror(errno));

		return TEST_FAIL;

	}



	return rip == (unsigned long) bp_1 ? TEST_OK : TEST_FAIL;

}



int test__bp_modify(struct test *test __maybe_unused,

		    int subtest __maybe_unused)

{

	TEST_ASSERT_VAL("modify test 1 failed\n", !bp_modify1());

	TEST_ASSERT_VAL("modify test 2 failed\n", !bp_modify2());



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE