Commit 9b3320ef authored Jan 27, 2015 by Ben Hutchings Committed by David S. Miller Jan 27, 2015

net: phy: Invalidate LP advertising flags when restarting or disabling AN



It is possible to see the old value of the LP advertising flags
through ethtool after reconfiguring the PHY and before autonegotiation
completes.  If autonegotiation is turned off then the last value seen
will persist indefinitely.

Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 28f323b3

drivers/net/phy/phy.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -439,6 +439,9 @@ int phy_start_aneg(struct phy_device *phydev)
		if (AUTONEG_DISABLE == phydev->autoneg)
		phy_sanitize_settings(phydev);

		/* Invalidate LP advertising flags */
		phydev->lp_advertising = 0;

		err = phydev->drv->config_aneg(phydev);
		if (err < 0)
		goto out_unlock;

Admin message