Commit 9b2b0971 authored Jun 29, 2020 by Lorenz Bauer Committed by Alexei Starovoitov Jun 30, 2020

bpf: sockmap: Check value of unused args to BPF_PROG_ATTACH

Using BPF_PROG_ATTACH on a sockmap program currently understands no
flags or replace_bpf_fd, but accepts any value. Return EINVAL instead.

Fixes: 604326b4 ("bpf, sockmap: convert to generic sk_msg interface")
Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200629095630.7933-4-lmb@cloudflare.com

parent 4ac2add6

net/core/sock_map.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -70,6 +70,9 @@ int sock_map_get_from_fd(const union bpf_attr attr, struct bpf_prog prog)
		struct fd f;
		int ret;

		if (attr->attach_flags \|\| attr->replace_bpf_fd)
		return -EINVAL;

		f = fdget(ufd);
		map = __bpf_map_get(f);
		if (IS_ERR(map))