Commit 9b0ed891 authored Nov 14, 2017 by Stephen Hemminger Committed by David S. Miller Nov 15, 2017

netem: remove unnecessary 64 bit modulus



Fix compilation on 32 bit platforms (where doing modulus operation
with 64 bit requires extra glibc functions) by truncation.
The jitter for table distribution is limited to a 32 bit value
because random numbers are scaled as 32 bit value.

Also fix some whitespace.

Fixes: 99803171 ("netem: add uapi to express delay and jitter in nanoseconds")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bce552fd

net/sched/sch_netem.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -312,7 +312,7 @@ static bool loss_event(struct netem_sched_data *q)
		* std deviation sigma. Uses table lookup to approximate the desired
		* distribution, and a uniformly-distributed pseudo-random source.
		*/
		static s64 tabledist(s64 mu, s64 sigma,
		static s64 tabledist(s64 mu, s32 sigma,
		struct crndstate *state,
		const struct disttable *dist)
		{

Admin message