Commit 9aeaf8cf authored Dec 06, 2018 by Olga Kornievskaia Committed by Anna Schumaker Jan 02, 2019

NFSv4.2 fix async copy reboot recovery



Original commit (e4648aa4 "NFS recover from destination server
reboot for copies") used memcmp() and then it was changed to use
nfs4_stateid_match_other() but that function returns opposite of
memcmp. As the result, recovery can't find the copy leading
to copy hanging.

Fixes: 80f42368 ("NFSv4: Split out NFS v4.2 copy completion functions")
Fixes: cb7a8384 ("NFS: Split out the body of nfs4_reclaim_open_state")
Signed-of-by: Olga Kornievskaia <kolga@netapp.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent f85adb1b

fs/nfs/nfs4state.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1555,7 +1555,7 @@ static void nfs42_complete_copies(struct nfs4_state_owner *sp, struct nfs4_state

		spin_lock(&sp->so_server->nfs_client->cl_lock);
		list_for_each_entry(copy, &sp->so_server->ss_copies, copies) {
		if (nfs4_stateid_match_other(&state->stateid, &copy->parent_state->stateid))
		if (!nfs4_stateid_match_other(&state->stateid, &copy->parent_state->stateid))
		continue;
		copy->flags = 1;
		complete(&copy->completion);

Admin message