Unverified Commit 9ad61b5c authored May 27, 2020 by Dinghao Liu Committed by Mark Brown May 27, 2020

ASoC: img-spdif-out: Fix runtime PM imbalance on error



pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200527084610.4790-1-dinghao.liu@zju.edu.cn


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 0d71a5cf

sound/soc/img/img-spdif-out.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -370,8 +370,10 @@ static int img_spdif_out_probe(struct platform_device *pdev)
		goto err_pm_disable;
		}
		ret = pm_runtime_get_sync(&pdev->dev);
		if (ret < 0)
		if (ret < 0) {
		pm_runtime_put_noidle(&pdev->dev);
		goto err_suspend;
		}

		img_spdif_out_writel(spdif, IMG_SPDIF_OUT_CTL_FS_MASK,
		IMG_SPDIF_OUT_CTL);

Admin message