ATA: piix, fix pointer deref on suspend (9ac62126) · Commits · 戴 / test

Hi, I've found this issue in the mmotm 2008-12-02-17-08. -- Commit ata_piix: add borked Tecra M4 to broken suspend list introduced DMI variables checking, but they can be null, so that we possibly dereference null. Check if they are null and avoid checks in that case. Solves: BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 IP: [<ffffffff8043da97>] piix_pci_device_suspend+0x117/0x230 Signed-off-by:

Jiri Slaby <jirislaby@gmail.com> Cc: Jeff Garzik <jgarzik@redhat.com> Cc: Alexandru Romanescu <a_romanescu@yahoo.co.uk> Cc: Tejun Heo <tj@kernel.org> Signed-off-by:

Jeff Garzik <jgarzik@redhat.com>

drivers/ata/ata_piix.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -1072,7 +1072,14 @@ static int piix_broken_suspend(void)
		* matching is necessary because dmi_system_id.matches is
		* limited to four entries.
		*/
		if (!strcmp(dmi_get_system_info(DMI_SYS_VENDOR), "TOSHIBA") &&
		if (dmi_get_system_info(DMI_SYS_VENDOR) &&
		dmi_get_system_info(DMI_PRODUCT_NAME) &&
		dmi_get_system_info(DMI_PRODUCT_VERSION) &&
		dmi_get_system_info(DMI_PRODUCT_SERIAL) &&
		dmi_get_system_info(DMI_BOARD_VENDOR) &&
		dmi_get_system_info(DMI_BOARD_NAME) &&
		dmi_get_system_info(DMI_BOARD_VERSION) &&
		!strcmp(dmi_get_system_info(DMI_SYS_VENDOR), "TOSHIBA") &&
		!strcmp(dmi_get_system_info(DMI_PRODUCT_NAME), "000000") &&
		!strcmp(dmi_get_system_info(DMI_PRODUCT_VERSION), "000000") &&
		!strcmp(dmi_get_system_info(DMI_PRODUCT_SERIAL), "000000") &&

Admin message