Commit 9abbffee authored Nov 24, 2006 by Masahide NAKAMURA Committed by David S. Miller Nov 25, 2006

[XFRM] STATE: Fix to respond error to get operation if no matching entry exists.



When application uses XFRM_MSG_GETSA to get state entry through
netlink socket and kernel has no matching one, the application expects
reply message with error status by kernel.

Kernel doesn't send the message back in the case of Mobile IPv6 route
optimization protocols (i.e. routing header or destination options
header). This is caused by incorrect return code "0" from
net/xfrm/xfrm_user.c(xfrm_user_state_lookup) and it makes kernel skip
to acknowledge at net/netlink/af_netlink.c(netlink_rcv_skb).

This patch fix to reply ESRCH to application.

Signed-off-by: Masahide NAKAMURA <nakam@linux-ipv6.org>
Signed-off-by: TAKAMIYA Noriaki <takamiya@po.ntts.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent dc9b3346

net/xfrm/xfrm_user.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -495,6 +495,7 @@ static struct xfrm_state xfrm_user_state_lookup(struct xfrm_usersa_id p,
		goto out;
		}

		err = -ESRCH;
		x = xfrm_state_lookup_byaddr(&p->daddr, saddr, p->proto,
		p->family);
		}

Admin message