Commit 9a975bee authored by Toshi Kani's avatar Toshi Kani Committed by Ingo Molnar
Browse files

drivers: Initialize resource entry to zero 



I/O resource descriptor, 'desc' in struct resource, needs to be
initialized to zero by default.  Some drivers call kmalloc() to
allocate a resource entry, but do not initialize it to zero by
memset().  Change these drivers to call kzalloc(), instead.

Signed-off-by: default avatarToshi Kani <toshi.kani@hpe.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Acked-by: default avatarAlexandre Bounine <alexandre.bounine@idt.com>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Luis R. Rodriguez <mcgrof@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: linux-acpi@vger.kernel.org
Cc: linux-arch@vger.kernel.org
Cc: linux-mm <linux-mm@kvack.org>
Cc: linux-parisc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-sh@vger.kernel.org
Link: http://lkml.kernel.org/r/1453841853-11383-10-git-send-email-bp@alien8.de


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 782b8664

drivers/acpi/acpi_platform.c

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev) 
	if (count < 0) {

		return NULL;

	} else if (count > 0) {

		resources = kmalloc(count * sizeof(struct resource),

		resources = kzalloc(count * sizeof(struct resource),

				    GFP_KERNEL);

		if (!resources) {

			dev_err(&adev->dev, "No memory for resources\n");

drivers/parisc/eisa_enumerator.c

+2 −2
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ static int configure_memory(const unsigned char *buf, 
	for (i=0;i<HPEE_MEMORY_MAX_ENT;i++) {

		c = get_8(buf+len);

		

		if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) {

		if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) {

			int result;

			

			res->name = name;
@@ -183,7 +183,7 @@ static int configure_port(const unsigned char *buf, struct resource *io_parent, 
	for (i=0;i<HPEE_PORT_MAX_ENT;i++) {

		c = get_8(buf+len);

		

		if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) {

		if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) {

			res->name = board;

			res->start = get_16(buf+len+1);

			res->end = get_16(buf+len+1)+(c&HPEE_PORT_SIZE_MASK)+1;

drivers/rapidio/rio.c

+4 −4
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ int rio_request_inb_mbox(struct rio_mport *mport, 
	if (mport->ops->open_inb_mbox == NULL)

		goto out;



	res = kmalloc(sizeof(struct resource), GFP_KERNEL);

	res = kzalloc(sizeof(struct resource), GFP_KERNEL);



	if (res) {

		rio_init_mbox_res(res, mbox, mbox);
@@ -185,7 +185,7 @@ int rio_request_outb_mbox(struct rio_mport *mport, 
	if (mport->ops->open_outb_mbox == NULL)

		goto out;



	res = kmalloc(sizeof(struct resource), GFP_KERNEL);

	res = kzalloc(sizeof(struct resource), GFP_KERNEL);



	if (res) {

		rio_init_mbox_res(res, mbox, mbox);
@@ -285,7 +285,7 @@ int rio_request_inb_dbell(struct rio_mport *mport, 
{

	int rc = 0;



	struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL);

	struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL);



	if (res) {

		rio_init_dbell_res(res, start, end);
@@ -360,7 +360,7 @@ int rio_release_inb_dbell(struct rio_mport *mport, u16 start, u16 end) 
struct resource *rio_request_outb_dbell(struct rio_dev *rdev, u16 start,

					u16 end)

{

	struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL);

	struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL);



	if (res) {

		rio_init_dbell_res(res, start, end);

drivers/sh/superhyway/superhyway.c

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ int superhyway_add_device(unsigned long base, struct superhyway_device *sdev, 
	superhyway_read_vcr(dev, base, &dev->vcr);



	if (!dev->resource) {

		dev->resource = kmalloc(sizeof(struct resource), GFP_KERNEL);

		dev->resource = kzalloc(sizeof(struct resource), GFP_KERNEL);

		if (!dev->resource) {

			kfree(dev);

			return -ENOMEM;

CRA Git | Maintained and supported by SUSTech CRA and CCSE