Commit 9a8c0fa8 authored by NeilBrown's avatar NeilBrown
Browse files

md: unlock mddev_lock on an error path. 



This error path retuns while still holding the lock - bad.

Fixes: 6791875e ("md: make reconfig_mutex optional for writes to md sysfs files.")
Cc: stable@vger.kernel.org (v4.0+)
Signed-off-by: default avatarNeilBrown <neilb@suse.com>
parent bd691922

drivers/md/md.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -4014,8 +4014,10 @@ new_dev_store(struct mddev *mddev, const char *buf, size_t len) 
	else

	else

		rdev = md_import_device(dev, -1, -1);

		rdev = md_import_device(dev, -1, -1);





	if (IS_ERR(rdev))

	if (IS_ERR(rdev)) {

		mddev_unlock(mddev);

		return PTR_ERR(rdev);

		return PTR_ERR(rdev);

	}

	err = bind_rdev_to_array(rdev, mddev);

	err = bind_rdev_to_array(rdev, mddev);

 out:

 out:

	if (err)

	if (err)

CRA Git | Maintained and supported by SUSTech CRA and CCSE