Commit 9a787546 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

PM: runtime: Replace pm_runtime_callbacks_present() 



The name of pm_runtime_callbacks_present() is confusing, because
it suggests that the device has PM-runtime callbacks if 'true' is
returned by that function, but in fact that may not be the case,
so replace it with pm_runtime_has_no_callbacks() which is not
ambiguous.

No functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 64c7d7ea

drivers/base/power/sysfs.c

+2 −2
Original line number Diff line number Diff line
@@ -666,7 +666,7 @@ int dpm_sysfs_add(struct device *dev) 
	if (rc)

		return rc;



	if (pm_runtime_callbacks_present(dev)) {

	if (!pm_runtime_has_no_callbacks(dev)) {

		rc = sysfs_merge_group(&dev->kobj, &pm_runtime_attr_group);

		if (rc)

			goto err_out;
@@ -709,7 +709,7 @@ int dpm_sysfs_change_owner(struct device *dev, kuid_t kuid, kgid_t kgid) 
	if (rc)

		return rc;



	if (pm_runtime_callbacks_present(dev)) {

	if (!pm_runtime_has_no_callbacks(dev)) {

		rc = sysfs_group_change_owner(

			&dev->kobj, &pm_runtime_attr_group, kuid, kgid);

		if (rc)

include/linux/pm_runtime.h

+2 −2
Original line number Diff line number Diff line
@@ -102,9 +102,9 @@ static inline bool pm_runtime_enabled(struct device *dev) 
	return !dev->power.disable_depth;

}



static inline bool pm_runtime_callbacks_present(struct device *dev)

static inline bool pm_runtime_has_no_callbacks(struct device *dev)

{

	return !dev->power.no_callbacks;

	return dev->power.no_callbacks;

}



static inline void pm_runtime_mark_last_busy(struct device *dev)

CRA Git | Maintained and supported by SUSTech CRA and CCSE