Commit 9a69bd19 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/todo: Add item for the plane->atomic_check confusion 



It's frankly a mess, and the confusion around plane_state->crtc/fb
that I fixed up in this series is the least of the problems. Add a
todo as a future note of how this could be done a lot better, and with
a lot less driver confusion.

Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191213172612.1514842-1-daniel.vetter@ffwll.ch
parent 39d0f1e8

Documentation/gpu/todo.rst

+22 −0
Original line number Diff line number Diff line
@@ -72,6 +72,28 @@ Contact: Ville Syrjälä, Daniel Vetter, driver maintainers 


Level: Advanced



Improve plane atomic_check helpers

----------------------------------



Aside from the clipped coordinates right above there's a few suboptimal things

with the current helpers:



- drm_plane_helper_funcs->atomic_check gets called for enabled or disabled

  planes. At best this seems to confuse drivers, worst it means they blow up

  when the plane is disabled without the CRTC. The only special handling is

  resetting values in the plane state structures, which instead should be moved

  into the drm_plane_funcs->atomic_duplicate_state functions.



- Once that's done, helpers could stop calling ->atomic_check for disabled

  planes.



- Then we could go through all the drivers and remove the more-or-less confused

  checks for plane_state->fb and plane_state->crtc.



Contact: Daniel Vetter



Level: Advanced



Convert early atomic drivers to async commit helpers

----------------------------------------------------

CRA Git | Maintained and supported by SUSTech CRA and CCSE