Commit 9a5f91a1 authored by Rajkumar Manoharan's avatar Rajkumar Manoharan Committed by Kalle Valo
Browse files

ath10k: release pre_cal_file while unloading driver 



Failing to release pre_cal_file caldata on deinit causes memory leak.

Fixes: b131129d ("ath10k: fix calibration init sequence of qca99x0")
Signed-off-by: default avatarRajkumar Manoharan <rmanohar@qti.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent fa7937e3

drivers/net/wireless/ath/ath10k/core.c

+4 −0
Original line number Diff line number Diff line
@@ -686,6 +686,9 @@ static void ath10k_core_free_firmware_files(struct ath10k *ar) 
	if (!IS_ERR(ar->cal_file))

		release_firmware(ar->cal_file);



	if (!IS_ERR(ar->pre_cal_file))

		release_firmware(ar->pre_cal_file);



	ath10k_swap_code_seg_release(ar);



	ar->normal_mode_fw.fw_file.otp_data = NULL;
@@ -696,6 +699,7 @@ static void ath10k_core_free_firmware_files(struct ath10k *ar) 
	ar->normal_mode_fw.fw_file.firmware_len = 0;



	ar->cal_file = NULL;

	ar->pre_cal_file = NULL;

}



static int ath10k_fetch_cal_file(struct ath10k *ar)

CRA Git | Maintained and supported by SUSTech CRA and CCSE