Commit 9a547c7e authored Nov 30, 2018 by Richard Guy Briggs Committed by Paul Moore Dec 03, 2018

audit: shorten PATH cap values when zero

Since the vast majority of files (99.993% on a typical system) have no
fcaps, display "0" instead of the full zero-padded 16 hex digits in the
two PATH record cap_f* fields to save netlink bandwidth and disk space.

Simply changing the format to %x won't work since the value is two (or
possibly more in the future) 32-bit hexadecimal values concatenated and
bits in higher order values will be misrepresented.

Passes audit-testsuite and userspace tools already work fine.
Please see the github issue tracker for more details
https://github.com/linux-audit/audit-kernel/issues/101



Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Acked-by: Steve Grubb <sgrubb@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>

parent 2a1fe215

kernel/audit.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -2059,11 +2059,13 @@ void audit_log_cap(struct audit_buffer ab, char prefix, kernel_cap_t *cap)
		{
		int i;

		audit_log_format(ab, " %s=", prefix);
		CAP_FOR_EACH_U32(i) {
		audit_log_format(ab, "%08x",
		cap->cap[CAP_LAST_U32 - i]);
		if (cap_isclear(*cap)) {
		audit_log_format(ab, " %s=0", prefix);
		return;
		}
		audit_log_format(ab, " %s=", prefix);
		CAP_FOR_EACH_U32(i)
		audit_log_format(ab, "%08x", cap->cap[CAP_LAST_U32 - i]);
		}

		static void audit_log_fcaps(struct audit_buffer ab, struct audit_names name)

Admin message