Commit 9a5094ca authored Jul 27, 2018 by Lars-Peter Clausen Committed by Jonathan Cameron Jul 28, 2018

iio: ad9523: Fix return value for ad952x_store()



A sysfs write callback function needs to either return the number of
consumed characters or an error.

The ad952x_store() function currently returns 0 if the input value was "0",
this will signal that no characters have been consumed and the function
will be called repeatedly in a loop indefinitely. Fix this by returning
number of supplied characters to indicate that the whole input string has
been consumed.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Fixes: cd1678f9 ("iio: frequency: New driver for AD9523 SPI Low Jitter Clock Generator")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 6d4abf1c

drivers/iio/frequency/ad9523.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -518,7 +518,7 @@ static ssize_t ad9523_store(struct device *dev,
		return ret;

		if (!state)
		return 0;
		return len;

		mutex_lock(&st->lock);
		switch ((u32)this_attr->address) {

Admin message