Commit 9a19a939 authored Aug 20, 2020 by Dinghao Liu Committed by Kalle Valo Aug 27, 2020

wilc1000: Fix memleak in wilc_bus_probe



When devm_clk_get() returns -EPROBE_DEFER, spi_priv
should be freed just like when wilc_cfg80211_init()
fails.

Fixes: 854d66df ("staging: wilc1000: look for rtc_clk clock in spi mode")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200820055256.24333-1-dinghao.liu@zju.edu.cn

parent 24712ea9

drivers/net/wireless/microchip/wilc1000/spi.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -112,9 +112,10 @@ static int wilc_bus_probe(struct spi_device *spi)
		wilc->dev_irq_num = spi->irq;

		wilc->rtc_clk = devm_clk_get(&spi->dev, "rtc_clk");
		if (PTR_ERR_OR_ZERO(wilc->rtc_clk) == -EPROBE_DEFER)
		if (PTR_ERR_OR_ZERO(wilc->rtc_clk) == -EPROBE_DEFER) {
		kfree(spi_priv);
		return -EPROBE_DEFER;
		else if (!IS_ERR(wilc->rtc_clk))
		} else if (!IS_ERR(wilc->rtc_clk))
		clk_prepare_enable(wilc->rtc_clk);

		return 0;

Admin message