Commit 9a0d9d03 authored by Lars Ellenberg's avatar Lars Ellenberg Committed by Philipp Reisner
Browse files

drbd: fix schedule in atomic 



An administrative detach used to request a state change directly to D_DISKLESS,
first suspending IO to avoid the last put_ldev() occuring from an endio handler,
potentially in irq context.

This is not enough on the receiving side (typically secondary), we may miss
some peer_req on the way to local disk, which then may do the last put_ldev()
from their drbd_peer_request_endio().

This patch makes the detach always go through the intermediate D_FAILED state.
We may consider to rename it D_DETACHING.

Alternative approach would be to create yet an other work item to be scheduled
on the worker, do the destructor work from there, and get the timing right.

manually picked commit 564040f from the drbd 8.4 branch.

Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
parent 99432fcc

drivers/block/drbd/drbd_int.h

+4 −0
Original line number Diff line number Diff line
@@ -2157,6 +2157,10 @@ static inline int get_net_conf(struct drbd_conf *mdev) 
static inline void put_ldev(struct drbd_conf *mdev)

{

	int i = atomic_dec_return(&mdev->local_cnt);



	/* This may be called from some endio handler,

	 * so we must not sleep here. */



	__release(local);

	D_ASSERT(i >= 0);

	if (i == 0) {

drivers/block/drbd/drbd_nl.c

+11 −3
Original line number Diff line number Diff line
@@ -1334,11 +1334,19 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp 
static int drbd_nl_detach(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp,

			  struct drbd_nl_cfg_reply *reply)

{

	enum drbd_ret_code retcode;

	int ret;

	drbd_suspend_io(mdev); /* so no-one is stuck in drbd_al_begin_io */

	reply->ret_code = drbd_request_state(mdev, NS(disk, D_DISKLESS));

	if (mdev->state.disk == D_DISKLESS)

		wait_event(mdev->misc_wait, !atomic_read(&mdev->local_cnt));

	retcode = drbd_request_state(mdev, NS(disk, D_FAILED));

	/* D_FAILED will transition to DISKLESS. */

	ret = wait_event_interruptible(mdev->misc_wait,

			mdev->state.disk != D_FAILED);

	drbd_resume_io(mdev);

	if (retcode == SS_IS_DISKLESS)

		retcode = SS_NOTHING_TO_DO;

	if (ret)

		retcode = ERR_INTR;

	reply->ret_code = retcode;

	return 0;

}

include/linux/drbd.h

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ 




extern const char *drbd_buildtag(void);

#define REL_VERSION "8.3.10"

#define REL_VERSION "8.3.11"

#define API_VERSION 88

#define PRO_VERSION_MIN 86

#define PRO_VERSION_MAX 96

CRA Git | Maintained and supported by SUSTech CRA and CCSE