Commit 99f81afc authored Feb 26, 2016 by Alexandre Belloni Committed by David S. Miller Mar 01, 2016

phy: micrel: Disable auto negotiation on startup



Disable auto negotiation on init to properly detect an already plugged
cable at boot.

At boot, when the phy is started, it is in the PHY_UP state.
However, if a cable is plugged at boot, because auto negociation is already
enabled at the time we get the first interrupt, the phy is already running.
But the state machine then switches from PHY_UP to PHY_AN and calls
phy_start_aneg(). phy_start_aneg() will not do anything because aneg is
already enabled on the phy. It will then wait for a interrupt before going
further. This interrupt will never happen unless the cable is unplugged and
then replugged.

It was working properly before 321beec5 (net: phy: Use interrupts when
available in NOLINK state) because switching to NOLINK meant starting
polling the phy, even if IRQ were enabled.

Fixes: 321beec5 (net: phy: Use interrupts when available in NOLINK state)
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f5aba91d

drivers/net/phy/micrel.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -297,6 +297,17 @@ static int kszphy_config_init(struct phy_device *phydev)
		if (priv->led_mode >= 0)
		kszphy_setup_led(phydev, type->led_mode_reg, priv->led_mode);

		if (phy_interrupt_is_valid(phydev)) {
		int ctl = phy_read(phydev, MII_BMCR);

		if (ctl < 0)
		return ctl;

		ret = phy_write(phydev, MII_BMCR, ctl & ~BMCR_ANENABLE);
		if (ret < 0)
		return ret;
		}

		return 0;
		}

Admin message