Commit 99d31cbd authored Jun 30, 2019 by Aya Levin Committed by Saeed Mahameed Jul 11, 2019

net/mlx5e: Fix error flow in tx reporter diagnose



Fix tx reporter's diagnose callback. Propagate error when failing to
gather diagnostics information or failing to print diagnostic data per
queue.

Fixes: de8650a8 ("net/mlx5e: Add tx reporter support")
Signed-off-by: Aya Levin <ayal@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 39825350

drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -262,13 +262,13 @@ static int mlx5e_tx_reporter_diagnose(struct devlink_health_reporter *reporter,

		err = mlx5_core_query_sq_state(priv->mdev, sq->sqn, &state);
		if (err)
		break;
		goto unlock;

		err = mlx5e_tx_reporter_build_diagnose_output(fmsg, sq->sqn,
		state,
		netif_xmit_stopped(sq->txq));
		if (err)
		break;
		goto unlock;
		}
		err = devlink_fmsg_arr_pair_nest_end(fmsg);
		if (err)

Admin message