Commit 99cefda4 authored Jun 27, 2008 by Louis Rilling Committed by Mark Fasheh Jul 31, 2008

[PATCH] configfs: Fix open directory making rmdir() fail



When checking for user-created elements under an item to be removed by rmdir(),
configfs_detach_prep() counts fake configfs_dirents created by dir_open() as
user-created and fails when finding one. It is however perfectly valid to remove
a directory that is open.

Simply make configfs_detach_prep() skip fake configfs_dirent, like it already
does for attributes, and like detach_groups() does.

Signed-off-by: Louis Rilling <louis.rilling@kerlabs.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>

parent 2e2ce171

fs/configfs/dir.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -435,7 +435,8 @@ static int configfs_detach_prep(struct dentry dentry, struct mutex *wait_mutex

		ret = 0;
		list_for_each_entry(sd, &parent_sd->s_children, s_sibling) {
		if (sd->s_type & CONFIGFS_NOT_PINNED)
		if (!sd->s_element \|\|
		(sd->s_type & CONFIGFS_NOT_PINNED))
		continue;
		if (sd->s_type & CONFIGFS_USET_DEFAULT) {
		/* Abort if racing with mkdir() */

Admin message