Commit 99c13853 authored by Ben Dooks's avatar Ben Dooks Committed by Russell King
Browse files

[ARM] 3627/1: S3C24XX: split s3c2410 clocks from core clocks 



Patch from Ben Dooks

Split the s3c2410 specific clocks from the core
clock code, as part of the work to support more
of the Samsung line of SoCs.

The patch does not use the sysdev mechanism as
the clocks are needed for the timer init, which
is very early in the kernel init sequence.

Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent a341305e

arch/arm/mach-s3c2410/Kconfig

+8 −0
Original line number Diff line number Diff line
@@ -114,9 +114,15 @@ config MACH_NEXCODER_2440 


endmenu



config S3C2410_CLOCK

	bool

	help

	  Clock code for the S3C2410, and similar processors



config CPU_S3C2410

	bool

	depends on ARCH_S3C2410

	select S3C2410_CLOCK

	help

	  Support for S3C2410 and S3C2410A family from the S3C24XX line

	  of Samsung Mobile CPUs.
@@ -130,6 +136,7 @@ config CPU_S3C244X 
config CPU_S3C2440

	bool

	depends on ARCH_S3C2410

	select S3C2410_CLOCK

	select CPU_S3C244X

	help

	  Support for S3C2440 Samsung Mobile CPU based systems.
@@ -137,6 +144,7 @@ config CPU_S3C2440 
config CPU_S3C2442

	bool

	depends on ARCH_S3C2420

	select S3C2410_CLOCK

	select CPU_S3C244X

	help

	  Support for S3C2442 Samsung Mobile CPU based systems.

arch/arm/mach-s3c2410/Makefile

+4 −0
Original line number Diff line number Diff line
@@ -29,6 +29,10 @@ obj-$(CONFIG_PM_SIMTEC) += pm-simtec.o 
obj-$(CONFIG_CPU_S3C244X)  += s3c244x.o

obj-$(CONFIG_CPU_S3C244X)  += s3c244x-irq.o



# Clock control



obj-$(CONFIG_S3C2410_CLOCK) += s3c2410-clock.o



# S3C2440 support



obj-$(CONFIG_CPU_S3C2440)  += s3c2440.o s3c2440-dsc.o

arch/arm/mach-s3c2410/clock.c

+7 −214
Original line number Diff line number Diff line
@@ -3,7 +3,7 @@ 
 * Copyright (c) 2004-2005 Simtec Electronics

 *	Ben Dooks <ben@simtec.co.uk>

 *

 * S3C2410 Clock control support

 * S3C24XX Core clock control support

 *

 * Based on, and code from linux/arch/arm/mach-versatile/clock.c

 **
@@ -56,25 +56,6 @@ static LIST_HEAD(clocks); 


DEFINE_MUTEX(clocks_mutex);



/* old functions */



void inline s3c24xx_clk_enable(unsigned int clocks, unsigned int enable)

{

	unsigned long clkcon;



	clkcon = __raw_readl(S3C2410_CLKCON);



	if (enable)

		clkcon |= clocks;

	else

		clkcon &= ~clocks;



	/* ensure none of the special function bits set */

	clkcon &= ~(S3C2410_CLKCON_IDLE|S3C2410_CLKCON_POWER | 3);



	__raw_writel(clkcon, S3C2410_CLKCON);

}



/* enable and disable calls for use with the clk struct */



static int clk_null_enable(struct clk *clk, int enable)
@@ -82,12 +63,6 @@ static int clk_null_enable(struct clk *clk, int enable) 
	return 0;

}



int s3c24xx_clkcon_enable(struct clk *clk, int enable)

{

	s3c24xx_clk_enable(clk->ctrlbit, enable);

	return 0;

}



/* Clock API calls */



struct clk *clk_get(struct device *dev, const char *id)
@@ -233,28 +208,6 @@ EXPORT_SYMBOL(clk_set_rate); 
EXPORT_SYMBOL(clk_get_parent);

EXPORT_SYMBOL(clk_set_parent);



/* base clock enable */



static int s3c24xx_upll_enable(struct clk *clk, int enable)

{

	unsigned long clkslow = __raw_readl(S3C2410_CLKSLOW);

	unsigned long orig = clkslow;



	if (enable)

		clkslow &= ~S3C2410_CLKSLOW_UCLK_OFF;

	else

		clkslow |= S3C2410_CLKSLOW_UCLK_OFF;



	__raw_writel(clkslow, S3C2410_CLKSLOW);



	/* if we started the UPLL, then allow to settle */



	if (enable && (orig & S3C2410_CLKSLOW_UCLK_OFF))

		udelay(200);



	return 0;

}



/* base clocks */



static struct clk clk_xtal = {
@@ -265,15 +218,14 @@ static struct clk clk_xtal = { 
	.ctrlbit	= 0,

};



static struct clk clk_upll = {

struct clk clk_upll = {

	.name		= "upll",

	.id		= -1,

	.parent		= NULL,

	.enable		= s3c24xx_upll_enable,

	.ctrlbit	= 0,

};



static struct clk clk_f = {

struct clk clk_f = {

	.name		= "fclk",

	.id		= -1,

	.rate		= 0,
@@ -281,7 +233,7 @@ static struct clk clk_f = { 
	.ctrlbit	= 0,

};



static struct clk clk_h = {

struct clk clk_h = {

	.name		= "hclk",

	.id		= -1,

	.rate		= 0,
@@ -289,7 +241,7 @@ static struct clk clk_h = { 
	.ctrlbit	= 0,

};



static struct clk clk_p = {

struct clk clk_p = {

	.name		= "pclk",

	.id		= -1,

	.rate		= 0,
@@ -426,108 +378,6 @@ struct clk s3c24xx_uclk = { 
	.id		= -1,

};





/* standard clock definitions */



static struct clk init_clocks[] = {

	{

		.name		= "nand",

		.id		= -1,

		.parent		= &clk_h,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_NAND,

	}, {

		.name		= "lcd",

		.id		= -1,

		.parent		= &clk_h,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_LCDC,

	}, {

		.name		= "usb-host",

		.id		= -1,

		.parent		= &clk_h,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_USBH,

	}, {

		.name		= "usb-device",

		.id		= -1,

		.parent		= &clk_h,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_USBD,

	}, {

		.name		= "timers",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_PWMT,

	}, {

		.name		= "sdi",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_SDI,

	}, {

		.name		= "uart",

		.id		= 0,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_UART0,

	}, {

		.name		= "uart",

		.id		= 1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_UART1,

	}, {

		.name		= "uart",

		.id		= 2,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_UART2,

	}, {

		.name		= "gpio",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_GPIO,

	}, {

		.name		= "rtc",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_RTC,

	}, {

		.name		= "adc",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_ADC,

	}, {

		.name		= "i2c",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_IIC,

	}, {

		.name		= "iis",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_IIS,

	}, {

		.name		= "spi",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c24xx_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_SPI,

	}, {

		.name		= "watchdog",

		.id		= -1,

		.parent		= &clk_p,

		.ctrlbit	= 0,

	}

};



/* initialise the clock system */



int s3c24xx_register_clock(struct clk *clk)
@@ -537,14 +387,6 @@ int s3c24xx_register_clock(struct clk *clk) 
	if (clk->enable == NULL)

		clk->enable = clk_null_enable;



	/* if this is a standard clock, set the usage state */



	if (clk->ctrlbit && clk->enable == s3c24xx_clkcon_enable) {

		unsigned long clkcon = __raw_readl(S3C2410_CLKCON);



		clk->usage = (clkcon & clk->ctrlbit) ? 1 : 0;

	}



	/* add to the list of available clocks */



	mutex_lock(&clocks_mutex);
@@ -561,44 +403,17 @@ int __init s3c24xx_setup_clocks(unsigned long xtal, 
				unsigned long hclk,

				unsigned long pclk)

{

	unsigned long upllcon = __raw_readl(S3C2410_UPLLCON);

	unsigned long clkslow = __raw_readl(S3C2410_CLKSLOW);

	struct clk *clkp = init_clocks;

	int ptr;

	int ret;



	printk(KERN_INFO "S3C2410 Clocks, (c) 2004 Simtec Electronics\n");

	printk(KERN_INFO "S3C24XX Clocks, (c) 2004 Simtec Electronics\n");



	/* initialise the main system clocks */



	clk_xtal.rate = xtal;

	clk_upll.rate = s3c2410_get_pll(upllcon, xtal);

	clk_upll.rate = s3c2410_get_pll(__raw_readl(S3C2410_UPLLCON), xtal);



	clk_h.rate = hclk;

	clk_p.rate = pclk;

	clk_f.rate = fclk;



	/* We must be careful disabling the clocks we are not intending to

	 * be using at boot time, as subsytems such as the LCD which do

	 * their own DMA requests to the bus can cause the system to lockup

	 * if they where in the middle of requesting bus access.

	 *

	 * Disabling the LCD clock if the LCD is active is very dangerous,

	 * and therefore the bootloader should be  careful to not enable

	 * the LCD clock if it is not needed.

	*/



	mutex_lock(&clocks_mutex);



	s3c24xx_clk_enable(S3C2410_CLKCON_NAND, 0);

	s3c24xx_clk_enable(S3C2410_CLKCON_USBH, 0);

	s3c24xx_clk_enable(S3C2410_CLKCON_USBD, 0);

	s3c24xx_clk_enable(S3C2410_CLKCON_ADC, 0);

	s3c24xx_clk_enable(S3C2410_CLKCON_IIC, 0);

	s3c24xx_clk_enable(S3C2410_CLKCON_SPI, 0);



	mutex_unlock(&clocks_mutex);



	/* assume uart clocks are correctly setup */



	/* register our clocks */
@@ -618,27 +433,5 @@ int __init s3c24xx_setup_clocks(unsigned long xtal, 
	if (s3c24xx_register_clock(&clk_p) < 0)

		printk(KERN_ERR "failed to register cpu pclk\n");





	if (s3c24xx_register_clock(&clk_usb_bus) < 0)

		printk(KERN_ERR "failed to register usb bus clock\n");



	/* register clocks from clock array */



	for (ptr = 0; ptr < ARRAY_SIZE(init_clocks); ptr++, clkp++) {

		ret = s3c24xx_register_clock(clkp);

		if (ret < 0) {

			printk(KERN_ERR "Failed to register clock %s (%d)\n",

			       clkp->name, ret);

		}

	}



	/* show the clock-slow value */



	printk("CLOCK: Slow mode (%ld.%ld MHz), %s, MPLL %s, UPLL %s\n",

	       print_mhz(xtal / ( 2 * S3C2410_CLKSLOW_GET_SLOWVAL(clkslow))),

	       (clkslow & S3C2410_CLKSLOW_SLOW) ? "slow" : "fast",

	       (clkslow & S3C2410_CLKSLOW_MPLL_OFF) ? "off" : "on",

	       (clkslow & S3C2410_CLKSLOW_UCLK_OFF) ? "off" : "on");



	return 0;

}

arch/arm/mach-s3c2410/clock.h

+9 −1
Original line number Diff line number Diff line
@@ -36,6 +36,13 @@ extern struct clk s3c24xx_uclk; 


extern struct clk clk_usb_bus;



/* core clock support */



extern struct clk clk_f;

extern struct clk clk_h;

extern struct clk clk_p;

extern struct clk clk_upll;



/* exports for arch/arm/mach-s3c2410

 *

 * Please DO NOT use these outside of arch/arm/mach-s3c2410
@@ -43,7 +50,8 @@ extern struct clk clk_usb_bus; 


extern struct mutex clocks_mutex;



extern int s3c24xx_clkcon_enable(struct clk *clk, int enable);

extern int s3c2410_clkcon_enable(struct clk *clk, int enable);



extern int s3c24xx_register_clock(struct clk *clk);



extern int s3c24xx_setup_clocks(unsigned long xtal,

arch/arm/mach-s3c2410/s3c2410-clock.c

0 → 100644
+263 −0
Original line number Diff line number Diff line 
/* linux/arch/arm/mach-s3c2410/clock.c

 *

 * Copyright (c) 2006 Simtec Electronics

 *	Ben Dooks <ben@simtec.co.uk>

 *

 * S3C2410,S3C2440,S3C2442 Clock control support

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License as published by

 * the Free Software Foundation; either version 2 of the License, or

 * (at your option) any later version.

 *

 * This program is distributed in the hope that it will be useful,

 * but WITHOUT ANY WARRANTY; without even the implied warranty of

 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

 * GNU General Public License for more details.

 *

 * You should have received a copy of the GNU General Public License

 * along with this program; if not, write to the Free Software

 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

*/



#include <linux/init.h>

#include <linux/module.h>

#include <linux/kernel.h>

#include <linux/list.h>

#include <linux/errno.h>

#include <linux/err.h>

#include <linux/sysdev.h>

#include <linux/clk.h>

#include <linux/mutex.h>

#include <linux/delay.h>



#include <asm/hardware.h>

#include <asm/io.h>



#include <asm/arch/regs-clock.h>

#include <asm/arch/regs-gpio.h>



#include "clock.h"

#include "cpu.h"



int s3c2410_clkcon_enable(struct clk *clk, int enable)

{

	unsigned int clocks = clk->ctrlbit;

	unsigned long clkcon;



	clkcon = __raw_readl(S3C2410_CLKCON);



	if (enable)

		clkcon |= clocks;

	else

		clkcon &= ~clocks;



	/* ensure none of the special function bits set */

	clkcon &= ~(S3C2410_CLKCON_IDLE|S3C2410_CLKCON_POWER);



	__raw_writel(clkcon, S3C2410_CLKCON);



	return 0;

}



static int s3c2410_upll_enable(struct clk *clk, int enable)

{

	unsigned long clkslow = __raw_readl(S3C2410_CLKSLOW);

	unsigned long orig = clkslow;



	if (enable)

		clkslow &= ~S3C2410_CLKSLOW_UCLK_OFF;

	else

		clkslow |= S3C2410_CLKSLOW_UCLK_OFF;



	__raw_writel(clkslow, S3C2410_CLKSLOW);



	/* if we started the UPLL, then allow to settle */



	if (enable && (orig & S3C2410_CLKSLOW_UCLK_OFF))

		udelay(200);



	return 0;

}



/* standard clock definitions */



static struct clk init_clocks_disable[] = {

	{

		.name		= "nand",

		.id		= -1,

		.parent		= &clk_h,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_NAND,

	}, {

		.name		= "sdi",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_SDI,

	}, {

		.name		= "adc",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_ADC,

	}, {

		.name		= "i2c",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_IIC,

	}, {

		.name		= "iis",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_IIS,

	}, {

		.name		= "spi",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_SPI,

	}

};



static struct clk init_clocks[] = {

	{

		.name		= "lcd",

		.id		= -1,

		.parent		= &clk_h,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_LCDC,

	}, {

		.name		= "gpio",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_GPIO,

	}, {

		.name		= "usb-host",

		.id		= -1,

		.parent		= &clk_h,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_USBH,

	}, {

		.name		= "usb-device",

		.id		= -1,

		.parent		= &clk_h,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_USBD,

	}, {

		.name		= "timers",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_PWMT,

	}, {

		.name		= "uart",

		.id		= 0,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_UART0,

	}, {

		.name		= "uart",

		.id		= 1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_UART1,

	}, {

		.name		= "uart",

		.id		= 2,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_UART2,

	}, {

		.name		= "rtc",

		.id		= -1,

		.parent		= &clk_p,

		.enable		= s3c2410_clkcon_enable,

		.ctrlbit	= S3C2410_CLKCON_RTC,

	}, {

		.name		= "watchdog",

		.id		= -1,

		.parent		= &clk_p,

		.ctrlbit	= 0,

	}

};



/* s3c2410_baseclk_add()

 *

 * Add all the clocks used by the s3c2410 or compatible CPUs

 * such as the S3C2440 and S3C2442.

 *

 * We cannot use a system device as we are needed before any

 * of the init-calls that initialise the devices are actually

 * done.

*/



int __init s3c2410_baseclk_add(void)

{

	unsigned long clkslow = __raw_readl(S3C2410_CLKSLOW);

	unsigned long clkcon  = __raw_readl(S3C2410_CLKCON);

	struct clk *clkp;

	struct clk *xtal;

	int ret;

	int ptr;



	clk_upll.enable = s3c2410_upll_enable;



	if (s3c24xx_register_clock(&clk_usb_bus) < 0)

		printk(KERN_ERR "failed to register usb bus clock\n");



	/* register clocks from clock array */



	clkp = init_clocks;

	for (ptr = 0; ptr < ARRAY_SIZE(init_clocks); ptr++, clkp++) {

		/* ensure that we note the clock state */



		clkp->usage = clkcon & clkp->ctrlbit ? 1 : 0;



		ret = s3c24xx_register_clock(clkp);

		if (ret < 0) {

			printk(KERN_ERR "Failed to register clock %s (%d)\n",

			       clkp->name, ret);

		}

	}



	/* We must be careful disabling the clocks we are not intending to

	 * be using at boot time, as subsytems such as the LCD which do

	 * their own DMA requests to the bus can cause the system to lockup

	 * if they where in the middle of requesting bus access.

	 *

	 * Disabling the LCD clock if the LCD is active is very dangerous,

	 * and therefore the bootloader should be careful to not enable

	 * the LCD clock if it is not needed.

	*/



	/* install (and disable) the clocks we do not need immediately */



	clkp = init_clocks_disable;

	for (ptr = 0; ptr < ARRAY_SIZE(init_clocks_disable); ptr++, clkp++) {



		ret = s3c24xx_register_clock(clkp);

		if (ret < 0) {

			printk(KERN_ERR "Failed to register clock %s (%d)\n",

			       clkp->name, ret);

		}



		s3c2410_clkcon_enable(clkp, 0);

	}



	/* show the clock-slow value */



	xtal = clk_get(NULL, "xtal");



	printk("CLOCK: Slow mode (%ld.%ld MHz), %s, MPLL %s, UPLL %s\n",

	       print_mhz(clk_get_rate(xtal) /

			 ( 2 * S3C2410_CLKSLOW_GET_SLOWVAL(clkslow))),

	       (clkslow & S3C2410_CLKSLOW_SLOW) ? "slow" : "fast",

	       (clkslow & S3C2410_CLKSLOW_MPLL_OFF) ? "off" : "on",

	       (clkslow & S3C2410_CLKSLOW_UCLK_OFF) ? "off" : "on");



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE