Commit 99bae5f9 authored Jun 12, 2014 by Li Zefan Committed by Tejun Heo Jun 17, 2014

cgroup: fix broken css_has_online_children()



After running:

  # mount -t cgroup cpu xxx /cgroup && mkdir /cgroup/sub && \
    rmdir /cgroup/sub && umount /cgroup

I found the cgroup root still existed:

  # cat /proc/cgroups
  #subsys_name    hierarchy       num_cgroups     enabled
  cpuset  0       1       1
  cpu     1       1       1
  ...

It turned out css_has_online_children() is broken.

Signed-off-by: Li Zefan <lizefan@huawei.com>
Sigend-off-by: Tejun Heo <tj@kernel.org>

parent ebe06187

kernel/cgroup.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3328,7 +3328,7 @@ bool css_has_online_children(struct cgroup_subsys_state *css)

		rcu_read_lock();
		css_for_each_child(child, css) {
		if (css->flags & CSS_ONLINE) {
		if (child->flags & CSS_ONLINE) {
		ret = true;
		break;
		}

Admin message