Commit 99a0fadf authored Dec 22, 2010 by Tejun Heo Committed by Jesse Barnes Dec 23, 2010

PCI: pci-stub: ignore zero-length id parameters



pci-stub uses strsep() to separate list of ids and generates a warning
message when it fails to parse an id.  However, not specifying the
parameter results in ids set to an empty string.  strsep() happily
returns the empty string as the first token and thus triggers the
warning message spuriously.

Make the tokner ignore zero length ids.

Reported-by: Chris Wright <chrisw@sous-sol.org>
Reported-by: Prasad Joshi <P.G.Joshi@student.reading.ac.uk>
Cc: stable@kernel.org
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent 9b444b36

drivers/pci/pci-stub.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -58,6 +58,9 @@ static int __init pci_stub_init(void)
		subdevice = PCI_ANY_ID, class=0, class_mask=0;
		int fields;

		if (!strlen(id))
		continue;

		fields = sscanf(id, "%x:%x:%x:%x:%x:%x",
		&vendor, &device, &subvendor, &subdevice,
		&class, &class_mask);

Admin message