Commit 9999370f authored Nov 02, 2016 by Cyrill Gorcunov Committed by David S. Miller Nov 03, 2016

net: ip, raw_diag -- Use jump for exiting from nested loop



I managed to miss that sk_for_each is called under "for"
cycle so need to use goto here to return matching socket.

CC: David S. Miller <davem@davemloft.net>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Ahern <dsa@cumulusnetworks.com>
CC: Andrey Vagin <avagin@openvz.org>
CC: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cd05a0ec

net/ipv4/raw_diag.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -79,10 +79,11 @@ static struct sock raw_sock_get(struct net net, const struct inet_diag_req_v2
	* hashinfo->lock here.		* hashinfo->lock here.
	*/		*/
	sock_hold(sk);		sock_hold(sk);
	break;		goto out_unlock;
	}		}
	}		}
	}		}
			out_unlock:
	read_unlock(&hashinfo->lock);		read_unlock(&hashinfo->lock);

	return sk ? sk : ERR_PTR(-ENOENT);		return sk ? sk : ERR_PTR(-ENOENT);

Admin message