Commit 9978339a authored by Thierry Reding's avatar Thierry Reding Committed by Linus Walleij
Browse files

pinctrl: tegra: xusb: Add note about legacy status 



Add a comment about why the call to of_match_node() cannot be replaced
by of_device_get_match_data(). This will hopefully prevent people from
attempting to clean this up in the future.

Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20190923095400.GA11084@ulmo


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 5ff8aca9

drivers/pinctrl/tegra/pinctrl-tegra-xusb.c

+6 −0
Original line number Diff line number Diff line
@@ -885,6 +885,12 @@ int tegra_xusb_padctl_legacy_probe(struct platform_device *pdev) 
	mutex_init(&padctl->lock);

	padctl->dev = &pdev->dev;



	/*

	 * Note that we can't replace this by of_device_get_match_data()

	 * because we need the separate matching table for this legacy code on

	 * Tegra124. of_device_get_match_data() would attempt to use the table

	 * from the updated driver and fail.

	 */

	match = of_match_node(tegra_xusb_padctl_of_match, pdev->dev.of_node);

	padctl->soc = match->data;

CRA Git | Maintained and supported by SUSTech CRA and CCSE