Commit 99687cdb authored Jan 18, 2019 by Luc Van Oostenryck Committed by Ingo Molnar Feb 11, 2019

sched/topology: Fix percpu data types in struct sd_data & struct s_data



The percpu members of struct sd_data and s_data are declared as:

	struct ... ** __percpu member;

So their type is:

	__percpu pointer to pointer to struct ...

But looking at how they're used, their type should be:

	pointer to __percpu pointer to struct ...

and they should thus be declared as:

	struct ... * __percpu *member;

So fix the placement of '__percpu' in the definition of these
structures.

This addresses a bunch of Sparse's warnings like:

	warning: incorrect type in initializer (different address spaces)
	  expected void const [noderef] <asn:3> *__vpp_verify
	  got struct sched_domain **

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190118144936.79158-1-luc.vanoostenryck@gmail.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent d0fe0b9c

include/linux/sched/topology.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -176,10 +176,10 @@ typedef int (*sched_domain_flags_f)(void);
		#define SDTL_OVERLAP 0x01

		struct sd_data {
		struct sched_domain **__percpu sd;
		struct sched_domain_shared **__percpu sds;
		struct sched_group **__percpu sg;
		struct sched_group_capacity **__percpu sgc;
		struct sched_domain __percpu sd;
		struct sched_domain_shared __percpu sds;
		struct sched_group __percpu sg;
		struct sched_group_capacity __percpu sgc;
		};

		struct sched_domain_topology_level {

kernel/sched/topology.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -705,7 +705,7 @@ cpu_attach_domain(struct sched_domain sd, struct root_domain rd, int cpu)
		}

		struct s_data {
		struct sched_domain ** __percpu sd;
		struct sched_domain * __percpu *sd;
		struct root_domain *rd;
		};

Admin message