Commit 9960a24a authored Dec 09, 2017 by Xiang Chen Committed by Martin K. Petersen Dec 20, 2017

scsi: hisi_sas: fix SAS_QUEUE_FULL problem while running IO



This patch fix SAS_QUEUE_FULL problem. The test situation is close port while
running IO.

In sas_eh_handle_sas_errors(), SCSI EH will free sas_task of the device if
lldd_I_T_nexus_reset() return TMF_RESP_FUNC_COMPLETE or -ENODEV.  But in our
SAS driver, we only free slots of the device when the return value is
TMF_RESP_FUNC_COMPLETE. So if the return value is -ENODEV, the slot resource
will not free any more.

As an solution, we should also free slots of the device in
lldd_I_T_nexus_reset() if the return value is -ENODEV.

Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 2a038131

drivers/scsi/hisi_sas/hisi_sas_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1308,7 +1308,7 @@ static int hisi_sas_I_T_nexus_reset(struct domain_device *device)

		rc = hisi_sas_debug_I_T_nexus_reset(device);

		if (rc == TMF_RESP_FUNC_COMPLETE) {
		if ((rc == TMF_RESP_FUNC_COMPLETE) \|\| (rc == -ENODEV)) {
		spin_lock_irqsave(&hisi_hba->lock, flags);
		hisi_sas_release_task(hisi_hba, device);
		spin_unlock_irqrestore(&hisi_hba->lock, flags);

Admin message