Commit 993b858e authored Dec 09, 2013 by Jon Paul Maloy Committed by David S. Miller Dec 10, 2013

tipc: correct the order of stopping services at rmmod



The 'signal handler' service in TIPC is a mechanism that makes it
possible to postpone execution of functions, by launcing them into
a job queue for execution in a separate tasklet, independent of
the launching execution thread.

When we do rmmod on the tipc module, this service is stopped after
the network service. At the same time, the stopping of the network
service may itself launch jobs for execution, with the risk that these
functions may be scheduled for execution after the data structures
meant to be accessed by the job have already been deleted. We have
seen this happen, most often resulting in an oops.

This commit ensures that the signal handler is the very first to be
stopped when TIPC is shut down, so there are no surprises during
the cleanup of the other services.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 388d3335

net/tipc/core.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -113,7 +113,6 @@ err:
		static void tipc_core_stop(void)
		{
		tipc_netlink_stop();
		tipc_handler_stop();
		tipc_cfg_stop();
		tipc_subscr_stop();
		tipc_nametbl_stop();
		@@ -146,9 +145,10 @@ static int tipc_core_start(void)
		res = tipc_subscr_start();
		if (!res)
		res = tipc_cfg_init();
		if (res)
		if (res) {
		tipc_handler_stop();
		tipc_core_stop();

		}
		return res;
		}

		@@ -178,6 +178,7 @@ static int __init tipc_init(void)

		static void __exit tipc_exit(void)
		{
		tipc_handler_stop();
		tipc_core_stop_net();
		tipc_core_stop();
		pr_info("Deactivated\n");

Admin message