Commit 9927c6fa authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

debugfs: remove return value of debugfs_create_atomic_t() 

No one checks the return value of debugfs_create_atomic_t(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Link: https://lore.kernel.org/r/20191016130332.GA28240@kroah.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c7c11689

Documentation/filesystems/debugfs.txt

+2 −2
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ lower-case values, or 1 or 0. Any other input will be silently ignored. 


Also, atomic_t values can be placed in debugfs with:



    struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,

    void debugfs_create_atomic_t(const char *name, umode_t mode,

				 struct dentry *parent, atomic_t *value)



A read of this file will get atomic_t values, and a write of this file

fs/debugfs/file.c

+4 −5
Original line number Diff line number Diff line
@@ -757,12 +757,11 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_atomic_t_wo, NULL, debugfs_atomic_t_set, 
 * @value: a pointer to the variable that the file should read to and write

 *         from.

 */

struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,

void debugfs_create_atomic_t(const char *name, umode_t mode,

			     struct dentry *parent, atomic_t *value)

{

	return debugfs_create_mode_unsafe(name, mode, parent, value,

					&fops_atomic_t, &fops_atomic_t_ro,

					&fops_atomic_t_wo);

	debugfs_create_mode_unsafe(name, mode, parent, value, &fops_atomic_t,

				   &fops_atomic_t_ro, &fops_atomic_t_wo);

}

EXPORT_SYMBOL_GPL(debugfs_create_atomic_t);

include/linux/debugfs.h

+6 −7
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ void debugfs_create_x64(const char *name, umode_t mode, struct dentry *parent, 
			u64 *value);

void debugfs_create_size_t(const char *name, umode_t mode,

			   struct dentry *parent, size_t *value);

struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,

void debugfs_create_atomic_t(const char *name, umode_t mode,

			     struct dentry *parent, atomic_t *value);

struct dentry *debugfs_create_bool(const char *name, umode_t mode,

				  struct dentry *parent, bool *value);
@@ -284,11 +284,10 @@ static inline void debugfs_create_size_t(const char *name, umode_t mode, 
					 struct dentry *parent, size_t *value)

{ }



static inline struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,

				     struct dentry *parent, atomic_t *value)

{

	return ERR_PTR(-ENODEV);

}

static inline void debugfs_create_atomic_t(const char *name, umode_t mode,

					   struct dentry *parent,

					   atomic_t *value)

{ }



static inline struct dentry *debugfs_create_bool(const char *name, umode_t mode,

						 struct dentry *parent,

CRA Git | Maintained and supported by SUSTech CRA and CCSE