Commit 9927af74 authored Jan 13, 2011 by Mel Gorman Committed by Linus Torvalds Jan 13, 2011

mm: compaction: perform a faster migration scan when migrating asynchronously



try_to_compact_pages() is initially called to only migrate pages
asychronously and kswapd always compacts asynchronously.  Both are being
optimistic so it is important to complete the work as quickly as possible
to minimise stalls.

This patch alters the scanner when asynchronous to only consider
MIGRATE_MOVABLE pageblocks as migration candidates.  This reduces stalls
when allocating huge pages while not impairing allocation success rates as
a full scan will be performed if necessary after direct reclaim.

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Rik van Riel <riel@redhat.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7f0f2496

mm/compaction.c

+15 −0

Original line number	Diff line number	Diff line
		@@ -240,6 +240,7 @@ static unsigned long isolate_migratepages(struct zone *zone,
		struct compact_control *cc)
		{
		unsigned long low_pfn, end_pfn;
		unsigned long last_pageblock_nr = 0, pageblock_nr;
		unsigned long nr_scanned = 0, nr_isolated = 0;
		struct list_head *migratelist = &cc->migratepages;

		@@ -280,6 +281,20 @@ static unsigned long isolate_migratepages(struct zone *zone,
		if (PageBuddy(page))
		continue;

		/*
		* For async migration, also only scan in MOVABLE blocks. Async
		* migration is optimistic to see if the minimum amount of work
		* satisfies the allocation
		*/
		pageblock_nr = low_pfn >> pageblock_order;
		if (!cc->sync && last_pageblock_nr != pageblock_nr &&
		get_pageblock_migratetype(page) != MIGRATE_MOVABLE) {
		low_pfn += pageblock_nr_pages;
		low_pfn = ALIGN(low_pfn, pageblock_nr_pages) - 1;
		last_pageblock_nr = pageblock_nr;
		continue;
		}

		/* Try isolate the page */
		if (__isolate_lru_page(page, ISOLATE_BOTH, 0) != 0)
		continue;

Admin message