usb: dwc2: Restore GUSBCFG in dwc2_get_hwparams() (99182467) · Commits · 戴 / test

Previously dwc2_get_hwparams() was changing GUSBCFG and not putting it back the way it was (specifically it set and cleared FORCEHOSTMODE). Since we want to move dwc2_core_reset() _before_ dwc2_get_hwparams() we should make sure dwc2_get_hwparams() isn't messing with things in a permanent way. Since we're now looking at GUSBCFG, it's obvious that we shouldn't need all the extra delays if FORCEHOSTMODE was already set. This will avoid some delays for any ports that have forced host mode. Signed-off-by:

Douglas Anderson <dianders@chromium.org> Signed-off-by:

John Youn <johnyoun@synopsys.com> Signed-off-by:

Felipe Balbi <balbi@ti.com>

drivers/usb/dwc2/core.c

+9 −7

Original line number	Diff line number	Diff line
		@@ -3129,18 +3129,20 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg)

		/* Force host mode to get HPTXFSIZ / GNPTXFSIZ exact power on value */
		gusbcfg = dwc2_readl(hsotg->regs + GUSBCFG);
		gusbcfg \|= GUSBCFG_FORCEHOSTMODE;
		dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG);
		if (!(gusbcfg & GUSBCFG_FORCEHOSTMODE)) {
		dwc2_writel(gusbcfg \| GUSBCFG_FORCEHOSTMODE,
		hsotg->regs + GUSBCFG);
		usleep_range(100000, 150000);
		}

		gnptxfsiz = dwc2_readl(hsotg->regs + GNPTXFSIZ);
		hptxfsiz = dwc2_readl(hsotg->regs + HPTXFSIZ);
		dev_dbg(hsotg->dev, "gnptxfsiz=%08x\n", gnptxfsiz);
		dev_dbg(hsotg->dev, "hptxfsiz=%08x\n", hptxfsiz);
		gusbcfg = dwc2_readl(hsotg->regs + GUSBCFG);
		gusbcfg &= ~GUSBCFG_FORCEHOSTMODE;
		if (!(gusbcfg & GUSBCFG_FORCEHOSTMODE)) {
		dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG);
		usleep_range(100000, 150000);
		}

		/* hwcfg2 */
		hw->op_mode = (hwcfg2 & GHWCFG2_OP_MODE_MASK) >>

Admin message