Commit 9900073c authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Thierry Reding
Browse files

pwm: lpss: Do not export board infos for different PWM types 



The PWM LPSS probe drivers just pass a pointer to the exported board
info structures to pwm_lpss_probe() based on device PCI or ACPI ID.

In order to remove the knowledge of specific devices from library part of
the driver and reduce noise in exported namespace just duplicate the
board info structures and stop exporting them.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 10d56a4c

drivers/pwm/pwm-lpss-pci.c

+21 −0
Original line number Diff line number Diff line
@@ -17,6 +17,27 @@ 


#include "pwm-lpss.h"



/* BayTrail */

static const struct pwm_lpss_boardinfo pwm_lpss_byt_info = {

	.clk_rate = 25000000,

	.npwm = 1,

	.base_unit_bits = 16,

};



/* Braswell */

static const struct pwm_lpss_boardinfo pwm_lpss_bsw_info = {

	.clk_rate = 19200000,

	.npwm = 1,

	.base_unit_bits = 16,

};



/* Broxton */

static const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = {

	.clk_rate = 19200000,

	.npwm = 4,

	.base_unit_bits = 22,

};



static int pwm_lpss_probe_pci(struct pci_dev *pdev,

			      const struct pci_device_id *id)

{

drivers/pwm/pwm-lpss-platform.c

+21 −0
Original line number Diff line number Diff line
@@ -18,6 +18,27 @@ 


#include "pwm-lpss.h"



/* BayTrail */

static const struct pwm_lpss_boardinfo pwm_lpss_byt_info = {

	.clk_rate = 25000000,

	.npwm = 1,

	.base_unit_bits = 16,

};



/* Braswell */

static const struct pwm_lpss_boardinfo pwm_lpss_bsw_info = {

	.clk_rate = 19200000,

	.npwm = 1,

	.base_unit_bits = 16,

};



/* Broxton */

static const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = {

	.clk_rate = 19200000,

	.npwm = 4,

	.base_unit_bits = 22,

};



static int pwm_lpss_probe_platform(struct platform_device *pdev)

{

	const struct pwm_lpss_boardinfo *info;

drivers/pwm/pwm-lpss.c

+0 −24
Original line number Diff line number Diff line
@@ -38,30 +38,6 @@ struct pwm_lpss_chip { 
	const struct pwm_lpss_boardinfo *info;

};



/* BayTrail */

const struct pwm_lpss_boardinfo pwm_lpss_byt_info = {

	.clk_rate = 25000000,

	.npwm = 1,

	.base_unit_bits = 16,

};

EXPORT_SYMBOL_GPL(pwm_lpss_byt_info);



/* Braswell */

const struct pwm_lpss_boardinfo pwm_lpss_bsw_info = {

	.clk_rate = 19200000,

	.npwm = 1,

	.base_unit_bits = 16,

};

EXPORT_SYMBOL_GPL(pwm_lpss_bsw_info);



/* Broxton */

const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = {

	.clk_rate = 19200000,

	.npwm = 4,

	.base_unit_bits = 22,

};

EXPORT_SYMBOL_GPL(pwm_lpss_bxt_info);



static inline struct pwm_lpss_chip *to_lpwm(struct pwm_chip *chip)

{

	return container_of(chip, struct pwm_lpss_chip, chip);

drivers/pwm/pwm-lpss.h

+0 −4
Original line number Diff line number Diff line
@@ -24,10 +24,6 @@ struct pwm_lpss_boardinfo { 
	unsigned long base_unit_bits;

};



extern const struct pwm_lpss_boardinfo pwm_lpss_byt_info;

extern const struct pwm_lpss_boardinfo pwm_lpss_bsw_info;

extern const struct pwm_lpss_boardinfo pwm_lpss_bxt_info;



struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, struct resource *r,

				     const struct pwm_lpss_boardinfo *info);

int pwm_lpss_remove(struct pwm_lpss_chip *lpwm);

CRA Git | Maintained and supported by SUSTech CRA and CCSE