usb: gadget: mass_storage: remove >= 0 check for unsigned type (98f3a1b9) · Commits · 戴 / test

drivers/usb/gadget/f_mass_storage.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1691,7 +1691,7 @@ static int check_command(struct fsg_common *common, int cmnd_size,
		int needs_medium, const char *name)
		{
		int i;
		int lun = common->cmnd[1] >> 5;
		unsigned int lun = common->cmnd[1] >> 5;
		static const char dirletter[4] = {'u', 'o', 'i', 'n'};
		char hdlen[20];
		struct fsg_lun *curlun;
		@@ -1757,7 +1757,7 @@ static int check_command(struct fsg_common *common, int cmnd_size,

		/* Check that the LUN values are consistent */
		if (common->lun != lun)
		DBG(common, "using LUN %d from CBW, not LUN %d from CDB\n",
		DBG(common, "using LUN %u from CBW, not LUN %u from CDB\n",
		common->lun, lun);

		/* Check the LUN */
		@@ -1777,7 +1777,7 @@ static int check_command(struct fsg_common *common, int cmnd_size,
		*/
		if (common->cmnd[0] != INQUIRY &&
		common->cmnd[0] != REQUEST_SENSE) {
		DBG(common, "unsupported LUN %d\n", common->lun);
		DBG(common, "unsupported LUN %u\n", common->lun);
		return -EINVAL;
		}
		}
		@@ -2169,7 +2169,7 @@ static int received_cbw(struct fsg_dev fsg, struct fsg_buffhd bh)
		if (common->data_size == 0)
		common->data_dir = DATA_DIR_NONE;
		common->lun = cbw->Lun;
		if (common->lun >= 0 && common->lun < common->nluns)
		if (common->lun < common->nluns)
		common->curlun = &common->luns[common->lun];
		else
		common->curlun = NULL;