Commit 98c8ee73 authored by Markus Elfring's avatar Markus Elfring Committed by Linus Walleij
Browse files

pinctrl: rockchip: Delete error messages for a failed memory allocation in two functions 



Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 5896c8d7

drivers/pinctrl/pinctrl-rockchip.c

+4 −9
Original line number Diff line number Diff line
@@ -2408,18 +2408,14 @@ static int rockchip_pinctrl_parse_dt(struct platform_device *pdev, 
	info->functions = devm_kzalloc(dev, info->nfunctions *

					      sizeof(struct rockchip_pmx_func),

					      GFP_KERNEL);

	if (!info->functions) {

		dev_err(dev, "failed to allocate memory for function list\n");

	if (!info->functions)

		return -EINVAL;

	}



	info->groups = devm_kzalloc(dev, info->ngroups *

					    sizeof(struct rockchip_pin_group),

					    GFP_KERNEL);

	if (!info->groups) {

		dev_err(dev, "failed allocate memory for ping group list\n");

	if (!info->groups)

		return -EINVAL;

	}



	i = 0;
@@ -2455,10 +2451,9 @@ static int rockchip_pinctrl_register(struct platform_device *pdev, 


	pindesc = devm_kzalloc(&pdev->dev, sizeof(*pindesc) *

			info->ctrl->nr_pins, GFP_KERNEL);

	if (!pindesc) {

		dev_err(&pdev->dev, "mem alloc for pin descriptors failed\n");

	if (!pindesc)

		return -ENOMEM;

	}



	ctrldesc->pins = pindesc;

	ctrldesc->npins = info->ctrl->nr_pins;

CRA Git | Maintained and supported by SUSTech CRA and CCSE