Commit 98c4f78d authored Nov 22, 2017 by Darrick J. Wong

xfs: always free inline data before resetting inode fork during ifree



In xfs_ifree, we reset the data/attr forks to extents format without
bothering to free any inline data buffer that might still be around
after all the blocks have been truncated off the file.  Prior to commit
43518812 ("xfs: remove support for inlining data/extents into the
inode fork") nobody noticed because the leftover inline data after
truncation was small enough to fit inside the inline buffer inside the
fork itself.

However, now that we've removed the inline buffer, we /always/ have to
free the inline data buffer or else we leak them like crazy.  This test
was found by turning on kmemleak for generic/001 or generic/388.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent 4fbd8d19

fs/xfs/xfs_inode.c

+21 −0

Original line number	Diff line number	Diff line
		@@ -2400,6 +2400,24 @@ retry:
		return 0;
		}

		/*
		* Free any local-format buffers sitting around before we reset to
		* extents format.
		*/
		static inline void
		xfs_ifree_local_data(
		struct xfs_inode *ip,
		int whichfork)
		{
		struct xfs_ifork *ifp;

		if (XFS_IFORK_FORMAT(ip, whichfork) != XFS_DINODE_FMT_LOCAL)
		return;

		ifp = XFS_IFORK_PTR(ip, whichfork);
		xfs_idata_realloc(ip, -ifp->if_bytes, whichfork);
		}

		/*
		* This is called to return an inode to the inode free list.
		* The inode should already be truncated to 0 length and have
		@@ -2437,6 +2455,9 @@ xfs_ifree(
		if (error)
		return error;

		xfs_ifree_local_data(ip, XFS_DATA_FORK);
		xfs_ifree_local_data(ip, XFS_ATTR_FORK);

		VFS_I(ip)->i_mode = 0; /* mark incore inode as free */
		ip->i_d.di_flags = 0;
		ip->i_d.di_dmevmask = 0;

Admin message