Commit 98b9e48f authored by Greg Rose's avatar Greg Rose Committed by Jeff Kirsher
Browse files

ixgbevf: Check if EOP has changed before using it 



There is a chance that between the time EOP is read and the time it is
used another transmit on a different CPU could have run and completed,
thus leaving EOP in a bad state.

Signed-off-by: default avatarGreg Rose <gregory.v.rose@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent dc221294

drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

+4 −0
Original line number Diff line number Diff line
@@ -203,6 +203,9 @@ static bool ixgbevf_clean_tx_irq(struct ixgbevf_adapter *adapter, 
	       (count < tx_ring->work_limit)) {

		bool cleaned = false;

		rmb(); /* read buffer_info after eop_desc */

		/* eop could change between read and DD-check */

		if (unlikely(eop != tx_ring->tx_buffer_info[i].next_to_watch))

			goto cont_loop;

		for ( ; !cleaned; count++) {

			struct sk_buff *skb;

			tx_desc = IXGBE_TX_DESC_ADV(*tx_ring, i);
@@ -232,6 +235,7 @@ static bool ixgbevf_clean_tx_irq(struct ixgbevf_adapter *adapter, 
				i = 0;

		}



cont_loop:

		eop = tx_ring->tx_buffer_info[i].next_to_watch;

		eop_desc = IXGBE_TX_DESC_ADV(*tx_ring, eop);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE